-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PlotTimeline
from optuna_dashboard/ts
to tslib/react
#951
Move PlotTimeline
from optuna_dashboard/ts
to tslib/react
#951
Conversation
46374d6
to
02ccc2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 70.00% 70.00%
=======================================
Files 35 35
Lines 2387 2387
=======================================
Hits 1671 1671
Misses 716 716 ☔ View full report in Codecov by Sentry. |
Fix lint Fix type error
628c4fe
to
c4f62e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! I just left one small comment.
Co-authored-by: Daichi Kato <[email protected]>
@porink0424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.