Convert deinit crash into warning

orlandos-nl · Aug 22, 2024 · 11566ed · 11566ed
1 parent bf3dfaa
commit 11566ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/Sources/Citadel/SFTP/Client/SFTPFile.swift b/Sources/Citadel/SFTP/Client/SFTPFile.swift
@@ -40,7 +40,9 @@ public final class SFTPFile {
     public var logger: Logging.Logger { self.client.logger }
 
     deinit {
-        assert(!self.client.isActive || !self.isActive, "SFTPFile deallocated without being closed first")
+        if client.isActive && self.isActive {
+            self.logger.warning("SFTPFile deallocated without being closed first")
+        }
     }
 
     /// Read the attributes of the file. This is equivalent to the `stat()` system call.

diff --git a/Tests/CitadelTests/Citadel2Tests.swift b/Tests/CitadelTests/Citadel2Tests.swift
@@ -253,6 +253,7 @@ final class Citadel2Tests: XCTestCase {
             _ = try await file.read(from: UInt64(i * 32_768), length: 32_768)
             i += 1
         }
+        try await file.close()
     }
 
     func testConnectToOpenSSHServer() async throws {