-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lynis baseline for aarch64 Tumbleweed #13375
Conversation
ggardet
commented
Oct 1, 2021
•
edited
Loading
edited
- Verification run:
- https://openqa.opensuse.org/t1950143
- https://openqa.opensuse.org/t1950144
Noteworthy diff to x86_64:
Shouldn't this blacklisting also appear on aarch64? |
CC @lilyeyes |
Thanks for the PR. |
I checked on a current tumbleweed x86 and there the modules are also not blacklisted. So it's fine to have this missing for aarch64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
They are blacklisted by Did you check using Lynis? If so, it might be a bug or intentional change in display. |
yes, I used Lynis on a fresh install. I have another look |
It's a lynis issue. I've sent a PR @lilyeyes: Shouldn't that have triggered the tests on x86 before as the baseline didn't match anymore? |
I have checked lynis baselines and current lynis outputs for sles15sp4 b47.1 on x86 and did not find the "Module * is blackedlisted [OK]". |
@lilyeyes The blacklisting is only on Tumbleweed. |
The list of files for each distro is here: https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master/data/lynis |
On TW, the openQA lynis test case found the difference between baseline and current lynis outputs but only checked the status as the contents are too complicated to check all of them (e.g., if the status is [ OK ] / [ YES ] / [ DONE ] then this item will be passed. if [ ERROR ] / ... / [WEAK] found then it will be failed, etc. ) FYI. IMO, if "[2C- Disable kernel support of some filesystems�[15C" contains the status like [OK] / [WEAK] test case can catch the bug. |
The CI is stuck on Running to isotovideo test, could you make a dummy force push to trigger it again? At least I do not have powers to kick the CI manually otherwise. |
740327d
to
b3507e5
Compare
Done |