Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lynis baseline for aarch64 Tumbleweed #13375

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

ggardet
Copy link
Collaborator

@ggardet ggardet commented Oct 1, 2021

@ggardet ggardet added the WIP Work in progress label Oct 1, 2021
@ggardet ggardet removed the WIP Work in progress label Oct 1, 2021
@Vogtinator
Copy link
Member

Noteworthy diff to x86_64:

   - Disable kernel support of some filesystems
-    - Module cramfs is blacklisted                            [ OK ]
-    - Module freevxfs is blacklisted                          [ OK ]
-    - Module hfs is blacklisted                               [ OK ]

Shouldn't this blacklisting also appear on aarch64?

@Vogtinator
Copy link
Member

CC @lilyeyes

@lilyeyes
Copy link
Contributor

lilyeyes commented Oct 8, 2021

Noteworthy diff to x86_64:

   - Disable kernel support of some filesystems
-    - Module cramfs is blacklisted                            [ OK ]
-    - Module freevxfs is blacklisted                          [ OK ]
-    - Module hfs is blacklisted                               [ OK ]

Shouldn't this blacklisting also appear on aarch64?

Thanks for the PR.
I am not sure if missing the blacklisting is OK. But I checked the lynis outputs for sle15sp4 on aarch64 it is the same with your baseline (no the Module * is blackedlisted [OK]). Etc, https://openqa.suse.de/assets/other/07274343-baseline-lynis-audit-system-nocolors-15-SP4-aarch64-textmode
You can ask [email protected] for a double check for TW.

@jsegitz
Copy link
Contributor

jsegitz commented Oct 13, 2021

I checked on a current tumbleweed x86 and there the modules are also not blacklisted. So it's fine to have this missing for aarch64.

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vogtinator
Copy link
Member

I checked on a current tumbleweed x86 and there the modules are also not blacklisted. So it's fine to have this missing for aarch64.

They are blacklisted by /usr/lib/modprobe.d/60-blacklist_fs-*.conf in the suse-module-tools package.

Did you check using Lynis? If so, it might be a bug or intentional change in display.

@jsegitz
Copy link
Contributor

jsegitz commented Oct 13, 2021

Did you check using Lynis? If so, it might be a bug or intentional change in display.

yes, I used Lynis on a fresh install. I have another look

@jsegitz
Copy link
Contributor

jsegitz commented Oct 13, 2021

It's a lynis issue. I've sent a PR
CISOfy/lynis#1215
and a fix is on the way to Factory:
https://build.opensuse.org/request/show/925115

@lilyeyes: Shouldn't that have triggered the tests on x86 before as the baseline didn't match anymore?

@lilyeyes
Copy link
Contributor

It's a lynis issue. I've sent a PR CISOfy/lynis#1215 and a fix is on the way to Factory: https://build.opensuse.org/request/show/925115

@lilyeyes: Shouldn't that have triggered the tests on x86 before as the baseline didn't match anymore?

I have checked lynis baselines and current lynis outputs for sles15sp4 b47.1 on x86 and did not find the "Module * is blackedlisted [OK]".
I have checked lynis baselines and current lynis outputs for sles15sp3 GM on x86 and did not find the "Module * is blackedlisted [OK]" as well.
If this "blackedlisted" is needed I will revise the baselines accordingly when the lynix fix is available for sles.

@ggardet
Copy link
Collaborator Author

ggardet commented Oct 14, 2021

@lilyeyes The blacklisting is only on Tumbleweed.

@ggardet
Copy link
Collaborator Author

ggardet commented Oct 14, 2021

The list of files for each distro is here: https://github.com/os-autoinst/os-autoinst-distri-opensuse/tree/master/data/lynis

@lilyeyes
Copy link
Contributor

@lilyeyes: Shouldn't that have triggered the tests on x86 before as the baseline didn't match anymore?

On TW, the openQA lynis test case found the difference between baseline and current lynis outputs but only checked the status as the contents are too complicated to check all of them (e.g., if the status is [ OK ] / [ YES ] / [ DONE ] then this item will be passed. if [ ERROR ] / ... / [WEAK] found then it will be failed, etc. )

FYI.
https://openqa.opensuse.org/tests/1966946#step/9_[+]_File_systems/4 (baseline)
https://openqa.opensuse.org/tests/1966946#step/9_[+]_File_systems/5 (current)

IMO, if "[2C- Disable kernel support of some filesystems�[15C" contains the status like [OK] / [WEAK] test case can catch the bug.

@tjyrinki
Copy link
Contributor

The CI is stuck on Running to isotovideo test, could you make a dummy force push to trigger it again? At least I do not have powers to kick the CI manually otherwise.

@ggardet
Copy link
Collaborator Author

ggardet commented Nov 17, 2021

The CI is stuck on Running to isotovideo test, could you make a dummy force push to trigger it again? At least I do not have powers to kick the CI manually otherwise.

Done

@tjyrinki tjyrinki merged commit 2d766f3 into os-autoinst:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants