Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitionEnd not defined, nasty bug #887

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

chrisgraham
Copy link

hasTransition is defined in the object, but transitionEnd is not.
This is a regression from previous behavior.

What this causes is the cookie dialog to disappear to opacity:0 but remain active in the DOM. It steals focus from anything under it, including form buttons.

@chrisgraham
Copy link
Author

I'm not in a position to set up a full JS build chain for this kind of thing and make a perfect commit, so I've put this pull request through as more of a bug report so you can see what needs fixing.

@chrisgraham
Copy link
Author

Also I wanted to note that contrary to https://www.osano.com/cookieconsent/documentation/javascript-api/ (which I understand may not represent the latest code in the Open Source repository), cookieconsent.hasTransition is not configurable in this code.

@ian-dowhile
Copy link

I'm seeing the same issue reported by users of smartphone devices. The cookie dialog sits over links and buttons, so although they are visible, they are not selectable by the user. Would be great to see this resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants