Handle Null Values #106
Open
Handle Null Values #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than the original data.
… either the x or y keys' values are null we'll remove those objects from the dataset.
…ar chart. The problem has to do with us using the scaleBand for the bars even when they're dates. We need to figure out how to use scaleTime.
removed import ChunkGraph
eiozalp
reviewed
May 4, 2022
| () => data.filter((el) => el[xKey] !== null && el[yKey] !== null), | ||
| [data] | ||
| ); | ||
|
|
There was a problem hiding this comment.
instead of copying this in each chart, we might want to add it to a util function and import it. @robcrock
eiozalp
reviewed
May 4, 2022
| @@ -391,6 +391,7 @@ export function transformSkinnyToWide( | |||
| xDataKey: string | undefined, | |||
| yDataKey: string | undefined | |||
| ) { | |||
| console.log('Function called.'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pass at improving how null values are handled.
Where this implementation is lacking:
However, this is still a step up, because we scatter, pie, line, bar, and area don't break when null values are referenced in the props.