Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create RunClient.ts and RunManager.ts with Test Files #46

Merged
merged 12 commits into from
Oct 4, 2024
Merged

feat: Create RunClient.ts and RunManager.ts with Test Files #46

merged 12 commits into from
Oct 4, 2024

Conversation

seneyu
Copy link
Contributor

@seneyu seneyu commented Oct 2, 2024

Linked issue/ticket

Description

Created and refactored RunClient.ts and RunManager.ts.
Created test files and tested locally.

However the RunManager.ts file uses ModelVersionClient, so there is an error for now.

Reproduction steps

Checklist

  • I've followed the Contributing guidelines
  • I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • I've linted, tested, and commented my code
  • I've updated documentation (if appropriate)

@yiqunzheng yiqunzheng merged commit 675813c into dev Oct 4, 2024
2 checks passed
@seneyu seneyu deleted the stephany/refactoring branch October 18, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiqunzheng yiqunzheng yiqunzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seneyu @yiqunzheng