Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Destructured imports in variable declarations, Refactor parser with Babel type guards #101

Closed
wants to merge 39 commits into from
Closed

Feature: Destructured imports in variable declarations, Refactor parser with Babel type guards #101

wants to merge 39 commits into from

Commits on Oct 1, 2021

  1. Merge pull request oslabs-beta#44 from oslabs-beta/dev 

    Github Actions CI/CD added to repo for PRs onto dev and master
    @labaird
    labaird authored Oct 1, 2021
    Configuration menu
    Copy the full SHA
    a09c4dd View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Merge pull request oslabs-beta#47 from oslabs-beta/dev 

    Merge dev into master
    @jo-cella
    jo-cella authored Oct 2, 2021
    Configuration menu
    Copy the full SHA
    91579c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Merge pull request oslabs-beta#52 from oslabs-beta/dev 

    Dev branch into master with initial version of website
    @charlesgutwirth
    charlesgutwirth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    fd83edb View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Merge pull request oslabs-beta#62 from oslabs-beta/dev 

    Dev to Master
    @charlesgutwirth
    charlesgutwirth authored Oct 5, 2021
    1 Configuration menu
    Copy the full SHA
    d0a2aa4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request oslabs-beta#64 from oslabs-beta/dev 

    Dev to Master
    @charlesgutwirth
    charlesgutwirth authored Oct 5, 2021
    1 Configuration menu
    Copy the full SHA
    2dbbbf3 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Merge pull request oslabs-beta#66 from oslabs-beta/dev 

    Dev to Master
    @PLCoster
    PLCoster authored Oct 6, 2021
    1 Configuration menu
    Copy the full SHA
    850f5f2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request oslabs-beta#69 from oslabs-beta/dev 

    Dev merged into master
    @jo-cella
    jo-cella authored Oct 6, 2021
    1 Configuration menu
    Copy the full SHA
    608f9d4 View commit details
    Browse the repository at this point in the history

  3. Merge pull request oslabs-beta#71 from oslabs-beta/dev 

    Merge Dev into Master, remove parser_setup folder from repo
    @jo-cella
    jo-cella authored Oct 6, 2021
    1 Configuration menu
    Copy the full SHA
    793ec4b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Merge pull request oslabs-beta#75 from oslabs-beta/dev 

    Dev to master
    @PLCoster
    PLCoster authored Oct 7, 2021
    1 Configuration menu
    Copy the full SHA
    1ea43dc View commit details
    Browse the repository at this point in the history

  2. Merge pull request oslabs-beta#80 from oslabs-beta/dev 

    Dev to Master
    @charlesgutwirth
    charlesgutwirth authored Oct 7, 2021
    1 Configuration menu
    Copy the full SHA
    82bc115 View commit details
    Browse the repository at this point in the history

  3. Merge pull request oslabs-beta#82 from oslabs-beta/dev 

    Dev to Master
    @charlesgutwirth
    charlesgutwirth authored Oct 7, 2021
    1 Configuration menu
    Copy the full SHA
    5a9ec6b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Merge pull request oslabs-beta#91 from oslabs-beta/dev 

    Dev to Master
    @charlesgutwirth
    charlesgutwirth authored Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4b1e5da View commit details
    Browse the repository at this point in the history

  2. Refractor A Few Files For Readability And Perhaps A Bit More Professi… 

    …onalism
    @hienqn
    hienqn committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b328db9 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Update SidebarProvider.ts

    @hienqn
    hienqn authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    e534db9 View commit details
    Browse the repository at this point in the history

  2. Update extension.ts

    @hienqn
    hienqn authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    8fccbe2 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge pull request oslabs-beta#93 from hienqn/feat/RefractorV.1 

    Refractor A Few Files For Readability And Improved TypeScript
    @PLCoster
    PLCoster authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    509652c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Refractor A Few Files For Readability And Perhaps A Bit More Professi… 

    …onalism

merge conflict
    @hienqn @MajorLift
    hienqn authored and MajorLift committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    03437f2 View commit details
    Browse the repository at this point in the history

  2. Update SidebarProvider.ts

    @hienqn @MajorLift
    hienqn authored and MajorLift committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    ef5b7f9 View commit details
    Browse the repository at this point in the history

  3. Update extension.ts

    @hienqn @MajorLift
    hienqn authored and MajorLift committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c1a5359 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. build: configure linter for strong typing 

    - relaxed some superfluous style rules
- set eslint scope to include webviews/
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    4eda7be View commit details
    Browse the repository at this point in the history

  2. style: use Record, Array type annotation 

    - Record<string, unknown> is default recommended by @typescript-eslint/ban-types.
- Using Array<T> when T is composite data type, and T[] when T is primitive is useful visual cue.
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    ec4d986 View commit details
    Browse the repository at this point in the history

  3. test: add tests for new features 

    * test 14: Folders as modules / batch exports / barrel files
- export * from './File'
import { File } from './dir'

* test 15:
- Variable declaration with..
a) object destructuring alias assignment
b) array destructuring
- Import Decaration with...
* glob import and namespace specifier

* See: Issue oslabs-beta#85, oslabs-beta#99
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    ccd630a View commit details
    Browse the repository at this point in the history

  4. refactor: add new types to use in parser

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    63aac11 View commit details
    Browse the repository at this point in the history

  5. refactor!: clarify parser logic using babel type guards 

    - Extensive rewrites in getImports(), findVarDecImports() methods
- Explicit checks with strong typing for all possible variations in import statements
- Passes all previously written tests
- Readability, modularity, extensibility improvements
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    1cd3446 View commit details
    Browse the repository at this point in the history

  6. feat: handle export batch declarations / barrel files 

    - passes test 14
- glob exports in general not yet supported

Fixes: Issue oslabs-beta#85
See: Issue oslabs-beta#99
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    2167e91 View commit details
    Browse the repository at this point in the history

  7. chore: update import statements

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    abf2848 View commit details
    Browse the repository at this point in the history

  8. style: use all caps for constant variable names

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0722429 View commit details
    Browse the repository at this point in the history

  9. feat: add uuid generator for tracking duplicate nodes 

    - files that are imported by multiple parents show up as duplicates in tree
- may be useful to keep track of these, while leaving nonce id as an access key for all instances
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f765d97 View commit details
    Browse the repository at this point in the history

  10. refactor: define interfaces for ComponentTree, TreeItem objects 

    - These class object implementations are tentative propsals
- May be advisable to decouple tree state data/logic from parsing functionality
- Parser can be converted to static class with no loss in utility
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    bc05391 View commit details
    Browse the repository at this point in the history

  11. style: add barrel files for cleaner imports

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    34e8726 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'feature/parser-type-guards,folder-modules'

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    02c05b3 View commit details
    Browse the repository at this point in the history

  13. feat: handle export batch declarations / barrel files 

    - passes test 14
- glob exports in general not yet supported

Fixes: Issue oslabs-beta#85
See: Issue oslabs-beta#99
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    6a69b49 View commit details
    Browse the repository at this point in the history

  14. refactor!: clarify parser logic using babel type guards 

    - Extensive rewrites in getImports(), findVarDecImports() methods
- Explicit checks with strong typing for all possible variations in import statements
- Passes all previously written tests
- Readability, modularity, extensibility improvements
    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0cf9617 View commit details
    Browse the repository at this point in the history

  15. refactor!: replace ImportObj type with ImportData

    @MajorLift
    MajorLift committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    7d71c57 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. build: add prettier to dev-deps

    @MajorLift
    MajorLift committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    b489746 View commit details
    Browse the repository at this point in the history

  2. chore: apply linter fixes

    @MajorLift
    MajorLift committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    78932b8 View commit details
    Browse the repository at this point in the history

  3. feat: support array destructuring in var. dec. 

    - e.g. const [foo, bar] = import('module');
    @MajorLift
    MajorLift committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    00e2195 View commit details
    Browse the repository at this point in the history

  4. chore: linter fix

    @MajorLift
    MajorLift committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    069ff63 View commit details
    Browse the repository at this point in the history

  5. fix: correctly display object,array destructured imports 

    - Also, barrel file feature needs more work
- Design decision on how to display glob imports required. Currently shows imported module in tree as single node.
    @MajorLift
    MajorLift committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e706c24 View commit details
    Browse the repository at this point in the history