Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote scripts/unembed-icons.py #2378

Draft
wants to merge 20 commits into
base: gh-pages
Choose a base branch
from

Conversation

Intrinsica1
Copy link
Contributor

@Intrinsica1 Intrinsica1 commented Jun 29, 2024

I have rewritten scripts/unembed-icons.py (now named unembed_icons.py), in order to fix #2375.

Right now only the basic functionality works (see gained features), but it is in an operational and maintainable state. I opened this pull so anyone who wants to contribute (especially to the TODOs in the code) is welcome.

Gained features:

  • works on all mime-types (not only PNGs)
  • it can automatically select a matching icon file from in the repo
  • you can choose the location and filename of the extracted icon file
  • does not mess with the formatting of the GeoJSON file
  • better file selector interfaces

Lost features:

  • operates on multiple GeoJSONs (TODO)
  • fully usable in the terminal (TODO)
  • adjustable log-level (TODO)
  • colored logging (TODO)
  • logs the space saved (easy to add, but not important)

@Intrinsica1 Intrinsica1 marked this pull request as draft June 30, 2024 13:21
@Intrinsica1
Copy link
Contributor Author

Is there a way to pause the CI on this pull?

@grischard
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unembed-icons.py only works on PNGs
2 participants