Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote scripts/unembed-icons.py #2378

Draft
wants to merge 20 commits into
base: gh-pages
Choose a base branch
from
Draft

Rewrote scripts/unembed-icons.py #2378

wants to merge 20 commits into from

Commits on Jun 29, 2024

  1. start refactor on unembed-icons: rename to unembed_icons to conform t… 

    …o PEP 8; start rewrite with getData(url)
    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ae50c1a View commit details
    Browse the repository at this point in the history

  2. implement findFile() for just binary data for now

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    c7cee09 View commit details
    Browse the repository at this point in the history

  3. support text data

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    fb7808c View commit details
    Browse the repository at this point in the history

  4. resolve "TODO: deduplicate reading file"

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    80fe800 View commit details
    Browse the repository at this point in the history

  5. added check counter

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    d2f7241 View commit details
    Browse the repository at this point in the history

  6. stop on invalid mime-type

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8e6ce95 View commit details
    Browse the repository at this point in the history

  7. almost at basic functionality (just missing replacing icon URL in the… 

    … GeoJSON)
    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    4f02fd6 View commit details
    Browse the repository at this point in the history

  8. basic functionality!

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    831e3a6 View commit details
    Browse the repository at this point in the history

  9. add note

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2159e0b View commit details
    Browse the repository at this point in the history

  10. add another note

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5af58c3 View commit details
    Browse the repository at this point in the history

  11. extra comments

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    1c2ee13 View commit details
    Browse the repository at this point in the history

  12. add comments

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    4af8de1 View commit details
    Browse the repository at this point in the history

  13. even more comments

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    80af05b View commit details
    Browse the repository at this point in the history

  14. edit & add comments

    @Intrinsica1
    Intrinsica1 committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    efc7ccc View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. ignore directories and hidden files when searching for icons + suppor… 

    …t invalid mime types
    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    5166fc2 View commit details
    Browse the repository at this point in the history

  2. handle canceling of Selection and Save As dialogs

    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    9daf9af View commit details
    Browse the repository at this point in the history

  3. gracefully handle if getData(url) returns None

    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    b4f0d51 View commit details
    Browse the repository at this point in the history

  4. confirm overwrites (now in a broken state)

    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    c59f546 View commit details
    Browse the repository at this point in the history

  5. return bools

    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    449805c View commit details
    Browse the repository at this point in the history

  6. more bools (has been in a working state since last commit)

    @Intrinsica1
    Intrinsica1 committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    eed7cb7 View commit details
    Browse the repository at this point in the history