Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: Filter normal read and write errors.(#3364) #3367

Open
wants to merge 1 commit into
base: 5.0release
Choose a base branch
from
Open

Exporter: Filter normal read and write errors.(#3364) #3367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion trunk/src/app/srs_app_statistic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,10 @@ void SrsStatistic::on_disconnect(std::string id, srs_error_t err)
stream->nb_clients--;
vhost->nb_clients--;

if (srs_error_code(err) != ERROR_SUCCESS) {
// TODO: FIXME: Should filter the err.
int err_code = srs_error_code(err);
if (err_code != ERROR_SUCCESS && err_code != ERROR_SOCKET_READ && err_code != ERROR_SOCKET_WRITE
Copy link
Member

@winlinvip winlinvip Jan 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using tags would be better to determine which errors can be ignored in PromQL.

code=1048, name=StreamIsBusy

TRANS_BY_GPT3

&& err_code != ERROR_SRT_IO) {
nb_errs_++;
}

Expand Down