Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing performance | Add shadow enabler #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Grozamir
Copy link

@Grozamir Grozamir commented Jun 13, 2024

In my app if count nodes more 30+, so then starting freezing and downing performance. The culprit of all this's shadows. I added enabler shadow. And now in my project disabled shadows and i can spawn very more nodes

There was a problem:
image

@Daguerreo
Copy link

Is it everything really necessary? It should be enough to check if the "ShadowColor" key is valid/populated and only in that case instance the shadow effect.

@Grozamir
Copy link
Author

It seems to me that it was natural to create a shadow switch.

@Daguerreo
Copy link

It seems to me that it was natural to create a shadow switch.

and what if the switch is true and the shadow color not setted?

@Grozamir
Copy link
Author

Then the shadow color will be Black (0, 0, 0)

@nolankramer
Copy link
Contributor

nolankramer commented Aug 16, 2024

This is a good idea for optimizing based on user's preference between appearance/drawing performance - however it may also warrant implementing shadow drawing ourselves - since it's likely we can make assumptions that Qt isn't aware of (or use a simpler method of drawing shadows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants