Fix FileUtilities sonar issue

pagopa · Sep 25, 2024 · e7891af · e7891af
1 parent dff7587
commit e7891af
Showing 1 changed file with 24 additions and 9 deletions.
diff --git a/src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java b/src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java
@@ -103,25 +103,40 @@ public static String toHexString(byte[] hash) {
 
     public static File fromStringToFile(String fileBase64) {
         try {
+
             byte[] decodedBytes = Base64.getDecoder().decode(fileBase64);
 
-            Path tempDir = Files.createTempDirectory("multipleUpload");
+            String secureDirPath = System.getProperty("java.io.tmpdir") + "/mySecureDirectory";
+            File secureDir = new File(secureDirPath);
+            if (!secureDir.exists() && !secureDir.mkdirs()) {
+                throw new IOException("Impossibile creare la directory sicura.");
+            }
 
-            Path tempFilePath;
 
             if (SystemUtils.IS_OS_UNIX) {
-                Set<PosixFilePermission> permissions = EnumSet.of(
+                Set<PosixFilePermission> dirPermissions = EnumSet.of(
+                        PosixFilePermission.OWNER_READ,
+                        PosixFilePermission.OWNER_WRITE,
+                        PosixFilePermission.OWNER_EXECUTE
+                );
+                java.nio.file.Files.setPosixFilePermissions(secureDir.toPath(), dirPermissions);
+            }
+
+            File tempFile;
+
+            if (SystemUtils.IS_OS_UNIX) {
+
+                Set<PosixFilePermission> filePermissions = EnumSet.of(
                         PosixFilePermission.OWNER_READ,
                         PosixFilePermission.OWNER_WRITE,
                         PosixFilePermission.OWNER_EXECUTE
                 );
-                FileAttribute<Set<PosixFilePermission>> fileAttributes = PosixFilePermissions.asFileAttribute(permissions);
 
-                tempFilePath = Files.createTempFile(tempDir, "tempfile", ".tmp", fileAttributes);
+                tempFile = File.createTempFile("tempfile", ".tmp", secureDir);
+                java.nio.file.Files.setPosixFilePermissions(tempFile.toPath(), filePermissions);
             } else {
-                tempFilePath = Files.createTempFile(tempDir, "tempfile", ".tmp");
 
-                File tempFile = tempFilePath.toFile();
+                tempFile = File.createTempFile("tempfile", ".tmp", secureDir);
 
                 boolean readable = tempFile.setReadable(true, true);
                 boolean writable = tempFile.setWritable(true, true);
@@ -132,11 +147,11 @@ public static File fromStringToFile(String fileBase64) {
                 }
             }
 
-            try (FileOutputStream fos = new FileOutputStream(tempFilePath.toFile())) {
+            try (FileOutputStream fos = new FileOutputStream(tempFile)) {
                 fos.write(decodedBytes);
             }
 
-            return tempFilePath.toFile();
+            return tempFile;
         } catch (IllegalArgumentException e) {
             log.error("Errore nella decodifica del Base64: " + e.getMessage());
             throw new AtmLayerException("Errore nella decodifica del File Base64", Response.Status.NOT_ACCEPTABLE, AppErrorCodeEnum.FILE_DECODE_ERROR);