merge dev in uat #192
Merged
merge dev in uat #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # helm-chart/Chart.yaml # pom.xml
# Conflicts: # _TMP/coverage-results.md # helm-chart/Chart.yaml # pom.xml # src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java # src/test/resources/integration-test/output/result.html # src/test/resources/integration-test/output/result.json
# Conflicts: # _TMP/coverage-results.md # helm-chart/Chart.yaml # pom.xml # src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java # src/test/resources/integration-test/output/result.html # src/test/resources/integration-test/output/result.json
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @Startup | ||
| static void init(@Observes StartupEvent ev) throws IOException { | ||
| String secureDirPath = System.getProperty("java.io.tmpdir") + "/decodedFilesDirectory"; |
Check warning
Code scanning / CodeQL
Local information disclosure in a temporary directory Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we should use the java.nio.file.Files.createTempDirectory method, which allows us to create a temporary directory with secure permissions from the start. This method ensures that the directory is created with permissions that restrict access to the owner only, thus preventing local information disclosure.
Steps to fix:
- Replace the use of
new Fileandmkdirs()withFiles.createTempDirectory. - Ensure that the directory is created with secure permissions from the start.
- Update the
decodedFilesDirectoryto use the path returned byFiles.createTempDirectory.
Suggested changeset
1
src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java
| @@ -26,7 +26,3 @@ | ||
| static void init(@Observes StartupEvent ev) throws IOException { | ||
| String secureDirPath = System.getProperty("java.io.tmpdir") + "/decodedFilesDirectory"; | ||
| decodedFilesDirectory = new File(secureDirPath); | ||
| if (!decodedFilesDirectory.exists() && !decodedFilesDirectory.mkdirs()) { | ||
| throw new IOException("Impossibile creare una directory sicura per il salvataggio di file temporanei."); | ||
| } | ||
| decodedFilesDirectory = java.nio.file.Files.createTempDirectory("decodedFilesDirectory").toFile(); | ||
| if (SystemUtils.IS_OS_UNIX) { |
Copilot is powered by AI and may make mistakes. Always verify output.
jacoco
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.