Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge uat in main #193

Merged
merged 85 commits into from
Sep 26, 2024
Merged

merge uat in main #193

merged 85 commits into from
Sep 26, 2024

Conversation

ElisKina-dev
Copy link
Collaborator

No description provided.

SMANUM and others added 30 commits May 31, 2024 10:42
@SMANUM @adrrss @actions-user
Dev (#165)
9807556 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
@LuciaM1 @adrrss
@actions-user @SMANUM
mergin dev into uat (#168)
0429705 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
@actions-user
feat: 0429705
305bc23
@actions-user
pom.xml updated with new version 1.17.0
73be9f0
@actions-user
Chart.yaml updated with new version v1.17.0
9e392a2
@actions-user
feat: docker-image: v1.17.0, chart: v1.17.0
634b6a1
@LuciaM1
Merge remote-tracking branch 'origin/main' into uat
d9b2bf4 
# Conflicts:
#	helm-chart/Chart.yaml
#	pom.xml
@GiacomoBrancazi @adrrss
@actions-user @SMANUM @LuciaM1
Dev (#170)
ba18749 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
@actions-user
feat: ba18749
1d184c8
@actions-user
pom.xml updated with new version 1.18.0
f03e112
@actions-user
Chart.yaml updated with new version v1.18.0
5a313ab
@actions-user
feat: docker-image: v1.18.0, chart: v1.18.0
08a051d
@LuciaM1 @adrrss
@actions-user @SMANUM @GiacomoBrancazi
merging dev into uat (#171)
fa4e97d 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
@actions-user
feat: fa4e97d
d3016d2
@actions-user
pom.xml updated with new version 1.19.0
95c7baf
@actions-user
Chart.yaml updated with new version v1.19.0
8394b14
@actions-user
feat: docker-image: v1.19.0, chart: v1.19.0
2492f8f
@adrrss
test 2 repliche
7540193
@adrrss
test 2 repliche
016c2e2
@adrrss
test 1 repliche
ed3c50e
@adrrss
test 3 repliche
c4ddcc8
@adrrss
test 3 repliche
f882b44
@adrrss
test 3 repliche
6bc79c3
@adrrss
test 3 repliche
d3d33ce
@adrrss
disable autoscaling
16be66d
@adrrss
ripristino autoscaling
59fc9f1
@LuciaM1 @adrrss
@actions-user @SMANUM @GiacomoBrancazi @ElisKina-dev @EmanueleValentini1 @GabrieleMaiocchiFilippo
merging dev into uat (#176)
fe5eec4 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: EmVal <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: Gabriele Maiocchi <[email protected]>
Co-authored-by: Giacomo Brancazi <[email protected]>
@actions-user
feat: fe5eec4
44c98ac
@actions-user
pom.xml updated with new version 1.20.0
dc19bb5
@actions-user
Chart.yaml updated with new version v1.20.0
0e3d0ab
LuciaM1 and others added 24 commits September 23, 2024 12:44
@LuciaM1 @adrrss
@actions-user @SMANUM @GiacomoBrancazi @ElisKina-dev @EmanueleValentini1 @GabrieleMaiocchiFilippo
merging dev into uat (#186)
ae74425 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: EmVal <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: Gabriele Maiocchi <[email protected]>
Co-authored-by: Giacomo Brancazi <[email protected]>
@actions-user
feat: ae74425
aeb13ae
@actions-user
pom.xml updated with new version 1.27.0
a9c362b
@actions-user
Chart.yaml updated with new version v1.27.0
e7409eb
@actions-user
feat: docker-image: v1.27.0, chart: v1.27.0
854f6cc
@LuciaM1
Merge remote-tracking branch 'origin/main' into uat
e86a950 
# Conflicts:
#	_TMP/coverage-results.md
#	helm-chart/Chart.yaml
#	pom.xml
#	src/main/java/it/gov/pagopa/atmlayer/service/model/service/impl/ResourceEntityServiceImpl.java
#	src/test/resources/integration-test/output/result.html
#	src/test/resources/integration-test/output/result.json
@EmanueleValentini1 @adrrss
@actions-user @SMANUM @LuciaM1 @GiacomoBrancazi @ElisKina-dev @GabrieleMaiocchiFilippo
Dev (#188)
488d079 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: Gabriele Maiocchi <[email protected]>
Co-authored-by: Giacomo Brancazi <[email protected]>
@actions-user
feat: 488d079
9b0e0fa
@actions-user
pom.xml updated with new version 1.28.0
e977add
@actions-user
Chart.yaml updated with new version v1.28.0
26cece8
@actions-user
feat: docker-image: v1.28.0, chart: v1.28.0
5ce2867
@EmanueleValentini1
Merge remote-tracking branch 'origin/main' into uat
bfb076e 
# Conflicts:
#	_TMP/coverage-results.md
#	helm-chart/Chart.yaml
#	pom.xml
#	src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java
#	src/test/resources/integration-test/output/result.html
#	src/test/resources/integration-test/output/result.json
@EmanueleValentini1 @adrrss
@actions-user @SMANUM @LuciaM1 @GiacomoBrancazi @ElisKina-dev @GabrieleMaiocchiFilippo
Dev (#190)
060f371 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: ElisKina-dev <[email protected]>
Co-authored-by: Gabriele Maiocchi <[email protected]>
Co-authored-by: Giacomo Brancazi <[email protected]>
@actions-user
feat: 060f371
a128086
@actions-user
pom.xml updated with new version 1.29.0
9651aef
@actions-user
Chart.yaml updated with new version v1.29.0
c8faf2b
@actions-user
feat: docker-image: v1.29.0, chart: v1.29.0
5f9263f
@EmanueleValentini1
Merge remote-tracking branch 'origin/main' into uat
0d2e34c 
# Conflicts:
#	_TMP/coverage-results.md
#	helm-chart/Chart.yaml
#	pom.xml
#	src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java
#	src/test/resources/integration-test/output/result.html
#	src/test/resources/integration-test/output/result.json
@ElisKina-dev @adrrss
@actions-user @SMANUM @LuciaM1 @GiacomoBrancazi @EmanueleValentini1 @GabrieleMaiocchiFilippo
merge dev in uat (#192)
a466066 
Co-authored-by: adrrossi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: adrrss <[email protected]>
Co-authored-by: SMANUM <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: GiacomoB <[email protected]>
Co-authored-by: Simone Munao <[email protected]>
Co-authored-by: LuciaM1 <[email protected]>
Co-authored-by: EmVal <[email protected]>
Co-authored-by: Gabriele Maiocchi <[email protected]>
Co-authored-by: Giacomo Brancazi <[email protected]>
@actions-user
feat: a466066
100bdee
@actions-user
pom.xml updated with new version 1.30.0
ada274c
@actions-user
Chart.yaml updated with new version v1.30.0
444f037
@actions-user
feat: docker-image: v1.30.0, chart: v1.30.0
d656f30
@ElisKina-dev
Merge remote-tracking branch 'origin/main' into uat
a964baa 
# Conflicts:
#	_TMP/coverage-results.md
#	helm-chart/Chart.yaml
#	pom.xml
#	src/main/java/it/gov/pagopa/atmlayer/service/model/utils/FileUtilities.java
#	src/test/resources/integration-test/output/result.html
#	src/test/resources/integration-test/output/result.json
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 26, 2024
View reviewed changes
src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java

@Startup
static void init(@Observes StartupEvent ev) throws IOException {
String secureDirPath = System.getProperty("java.io.tmpdir") + "/decodedFilesDirectory";

Check warning

Code scanning / CodeQL

Local information disclosure in a temporary directory Medium

Local information disclosure vulnerability from
system temp directory
Loading
due to use of file or directory readable by other local users.
Local information disclosure vulnerability from
system temp directory
Loading
due to use of file or directory readable by other local users.

Copilot Autofix AI about 2 months ago

To fix the problem, we should use the java.nio.file.Files.createTempDirectory method, which allows us to create a temporary directory with secure permissions from the start. This method ensures that the directory is created with permissions that restrict access to the owner only, thus preventing local information disclosure.

Steps to fix:

  1. Replace the use of new File and mkdirs() with Files.createTempDirectory.
  2. Ensure that the directory is created with secure permissions from the start.
  3. Update the decodedFilesDirectory to use the path returned by Files.createTempDirectory.
Suggested changeset 1
src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java b/src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java
--- a/src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java
+++ b/src/main/java/it/gov/pagopa/atmlayer/service/model/configurations/DirManager.java
@@ -26,7 +26,3 @@
     static void init(@Observes StartupEvent ev) throws IOException {
-        String secureDirPath = System.getProperty("java.io.tmpdir") + "/decodedFilesDirectory";
-        decodedFilesDirectory = new File(secureDirPath);
-        if (!decodedFilesDirectory.exists() && !decodedFilesDirectory.mkdirs()) {
-            throw new IOException("Impossibile creare una directory sicura per il salvataggio di file temporanei.");
-        }
+        decodedFilesDirectory = java.nio.file.Files.createTempDirectory("decodedFilesDirectory").toFile();
         if (SystemUtils.IS_OS_UNIX) {
EOF
@@ -26,7 +26,3 @@
static void init(@Observes StartupEvent ev) throws IOException {
String secureDirPath = System.getProperty("java.io.tmpdir") + "/decodedFilesDirectory";
decodedFilesDirectory = new File(secureDirPath);
if (!decodedFilesDirectory.exists() && !decodedFilesDirectory.mkdirs()) {
throw new IOException("Impossibile creare una directory sicura per il salvataggio di file temporanei.");
}
decodedFilesDirectory = java.nio.file.Files.createTempDirectory("decodedFilesDirectory").toFile();
if (SystemUtils.IS_OS_UNIX) {
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@ElisKina-dev ElisKina-dev merged commit 79dfa59 into main Sep 26, 2024
9 of 10 checks passed
@github-actions GitHub Actions
Copy link

jacoco

File Coverage [87.95%] 🍏
ResourceEntityServiceImpl.java 94.01% 🍏
DirManager.java 72.09% ❌
FileUtilities.java 71.04% ❌
Total Project Coverage 92.95% 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmanueleValentini1 EmanueleValentini1 EmanueleValentini1 approved these changes

@LuciaM1 LuciaM1 Awaiting requested review from LuciaM1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ElisKina-dev @EmanueleValentini1 @SMANUM @LuciaM1 @actions-user @GiacomoBrancazi @adrrss