IMN-221 Agreement Submit test (#603)

Co-authored-by: Eric Camellini <[email protected]>
pagopa · Jun 12, 2024 · 7a5ba15 · 7a5ba15
1 parent ec7deae
commit 7a5ba15
Show file tree

Hide file tree

Showing 4 changed files with 2,164 additions and 14 deletions.
diff --git a/packages/agreement-process/src/services/agreementService.ts b/packages/agreement-process/src/services/agreementService.ts
@@ -380,7 +380,12 @@ export function agreementServiceBuilder(
         readModelService
       );
 
-      await validateConsumerEmail(agreement.data, readModelService);
+      const consumer = await retrieveTenant(
+        agreement.data.consumerId,
+        readModelService
+      );
+
+      await validateConsumerEmail(consumer, agreement.data);
 
       const eservice = await retrieveEService(
         agreement.data.eserviceId,
@@ -392,11 +397,6 @@ export function agreementServiceBuilder(
         agreement.data.descriptorId
       );
 
-      const consumer = await retrieveTenant(
-        agreement.data.consumerId,
-        readModelService
-      );
-
       const producer = await retrieveTenant(
         agreement.data.producerId,
         readModelService
@@ -503,6 +503,11 @@ export function agreementServiceBuilder(
             );
 
       const archivedAgreementsUpdates: Array<CreateEvent<AgreementEvent>> =
+        /* 
+          This condition can only check if state is ACTIVE
+          at this point the SUSPENDED state is not available 
+          after validateActiveOrPendingAgreement validation
+        */
         isActiveOrSuspended(submittedAgreement.state)
           ? agreements.map((agreement) =>
               createAgreementArchivedByUpgradeEvent(

diff --git a/packages/agreement-process/src/services/agreementSubmissionProcessor.ts b/packages/agreement-process/src/services/agreementSubmissionProcessor.ts
@@ -25,9 +25,7 @@ import {
   matchingVerifiedAttributes,
 } from "../model/domain/validators.js";
 import { ApiAgreementSubmissionPayload } from "../model/types.js";
-import { retrieveTenant } from "./agreementService.js";
 import { createStamp } from "./agreementStampUtils.js";
-import { ReadModelService } from "./readModelService.js";
 
 export type AgremeentSubmissionResults = {
   events: Array<CreateEvent<AgreementEvent>>;
@@ -36,11 +34,9 @@ export type AgremeentSubmissionResults = {
 };
 
 export const validateConsumerEmail = async (
-  agreement: Agreement,
-  readModelService: ReadModelService
+  consumer: Tenant,
+  agreement: Agreement
 ): Promise<void> => {
-  const consumer = await retrieveTenant(agreement.consumerId, readModelService);
-
   const hasContactEmail = consumer.mails.some(
     (mail) => mail.kind === tenantMailKind.ContactEmail
   );