IMN-839 Return false if certified attributes is empty (#1033)

Co-authored-by: Vittorio Caprio <[email protected]>
pagopa · Sep 30, 2024 · 91ef664 · 91ef664
1 parent 647c243
commit 91ef664
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/agreement-lifecycle/src/validator/attributesValidator.ts b/packages/agreement-lifecycle/src/validator/attributesValidator.ts
@@ -20,12 +20,14 @@ const attributesSatisfied = (
   descriptorAttributes: EServiceAttribute[][],
   consumerAttributeIds: Array<TenantAttribute["id"]>
 ): boolean =>
-  descriptorAttributes.every((attributeList) => {
-    const attributes = attributeList.map((a) => a.id);
-    return (
-      attributes.filter((a) => consumerAttributeIds.includes(a)).length > 0
-    );
-  });
+  descriptorAttributes
+    .filter((attGroup) => attGroup.length > 0)
+    .every((attributeList) => {
+      const attributes = attributeList.map((a) => a.id);
+      return (
+        attributes.filter((a) => consumerAttributeIds.includes(a)).length > 0
+      );
+    });
 
 export const certifiedAttributesSatisfied = (
   descriptor: DescriptorWithOnlyAttributes,