IMN-869: removed contentType' checks on download #1052
+6
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsterITA
requested review from
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
as code owners
ecamellini
reviewed
Oct 2, 2024
| @@ -359,18 +358,6 @@ export function contractException(agreementId: string): ApiError<ErrorCodes> { | |||
| }); | |||
| } | |||
|
|
|||
| export function invalidContentType( | |||
There was a problem hiding this comment.
You can also remove invalidRiskAnalysisContentType which is an error similar to this one, probably unused now
ecamellini
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-869
This PR addresses an issue encountered when downloading documents, where the following error is triggered:
Invalid contentType application/pdf for document.In the Scala implementation, this check was used solely to assign the
contentTypeto the generatedHttpEntity. However, in here, we don't need to explicitly set acontentTypefor the returned object. As a result, this check is no longer necessary.