IMN-521 - Replace Fastify with Express in authorization-server #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taglioni-r
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
…a/interop-be-monorepo into IMN-521_fastify-to-express
…a/interop-be-monorepo into IMN-521_fastify-to-express
galales
approved these changes
Nov 14, 2024
| @@ -1 +1 @@ | |||
| CLIENT_ASSERTION_AUDIENCE="test.interop.pagopa.it,dev.interop.pagopa.it" | |||
| CLIENT_ASSERTION_AUDIENCE="auth.refactor.dev.interop.pagopa.it/client-assertion,auth.refactor.test.interop.pagopa.it/client-assertion" | |||
There was a problem hiding this comment.
not sure about the scope, but refactor.test is not used
| @@ -109,6 +109,8 @@ export function tokenServiceBuilder({ | |||
| verifyClientAssertion(request.client_assertion, request.client_id); | |||
|
|
|||
| if (clientAssertionErrors) { | |||
| // TODO double check if errors have to be logged or put inside the error below (check the same for parameters errors) | |||
| logger.warn(clientAssertionErrors.map((error) => error.detail)); | |||
There was a problem hiding this comment.
the error message should already be logged (I don't recall, in makeApiProblem maybe), so we can put the errors in the exception and use the standard flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #1086
Replaced Fastify with Express in
authorization-server