PIN 5554 eservice isDelegable #1188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalpenZibo
changed the title
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
ffee648
to
0f7ec96
Compare
ecamellini
added
tenant-process
Incaricato
catalog-process
and removed
tenant-process
labels
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
9ea2f01
to
a8eff9f
Compare
MalpenZibo
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
7e63dcc
to
1bf21ef
Compare
ecamellini
requested changes
Nov 15, 2024
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
2dad452
to
242a9f2
Compare
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
242a9f2
to
38e56fe
Compare
paologaleotti
approved these changes
Nov 19, 2024
ecamellini
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Three things are still missing IMO:
- Adding the flag into the various read calls in BFF and API GW (only the ones that don't return compact data)
- Adding the flag into the eservice import/export in BFF (see fileUtils.ts)
- Updating the corresponding Bruno calls, performing some manual tests, and adding some test screenshots to the PR
You can use #1109 as a reference for all the points, where I did the same for the isSignalHubEnabled flag. I would do these things into the same PR so that it becomes another good reference on how to add a new field into a model in the future
| @@ -60,6 +60,7 @@ describe("get eservices", () => { | |||
| name: "eservice 001 test", | |||
| descriptors: [descriptor1], | |||
| producerId: organizationId1, | |||
| isDelegable: true, | |||
There was a problem hiding this comment.
Could you add isSignalHubEnabled here as well? I forgot to add it in #1109
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
e4b8708
to
633f044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PIN-5554
This PR:
The ability to change this flag on published events will be implemented in this task https://pagopa.atlassian.net/browse/PIN-5700
Manual Test
Create eservice
Update Draft
Get eservice descriptor
Get producer eservice
Get producer eservice descriptor
API GW Get Eservice