Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIN-5563 Fix bug wsdl #1201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PIN-5563 Fix bug wsdl #1201

wants to merge 1 commit into from

Conversation

sandrotaje
Copy link
Collaborator

No description provided.

ecamellini
ecamellini previously approved these changes Nov 13, 2024
View reviewed changes
AsterITA
AsterITA previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@AsterITA AsterITA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think it's worth adding some tests here, I added another task for that here in order to remember to do it in the future

@sandrotaje sandrotaje changed the base branch from develop to main November 18, 2024 22:02
@sandrotaje sandrotaje dismissed stale reviews from AsterITA and ecamellini November 18, 2024 22:02

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecamellini ecamellini ecamellini approved these changes

@beetlecrunch beetlecrunch Awaiting requested review from beetlecrunch beetlecrunch is a code owner

@galales galales Awaiting requested review from galales galales is a code owner

@Carminepo2 Carminepo2 Awaiting requested review from Carminepo2 Carminepo2 is a code owner

@taglioni-r taglioni-r Awaiting requested review from taglioni-r taglioni-r is a code owner

@AsterITA AsterITA Awaiting requested review from AsterITA AsterITA is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrotaje @ecamellini @AsterITA