IMN-415 add consumerServiceV2 in tenant-readmodel-writer #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or_logic_function_in_tenant-process
…or_logic_function_in_tenant-process
… IMN-296_update_return_as_scala
…or_logic_function_in_tenant-process
… IMN-296_update_return_as_scala
… IMN-296_update_return_as_scala
…interop-be-monorepo into IMN-384_tenant-events-v2
…ceV2_in_tenant_readmodel_writer
…ceV2_in_tenant_readmodel_writer
galales
reviewed
Jul 12, 2024
packages/tenant-readmodel-writer/src/tenantConsumerServiceV2.ts
Outdated
Show resolved
Hide resolved
packages/tenant-readmodel-writer/src/tenantConsumerServiceV1.ts
Outdated
Show resolved
Hide resolved
packages/tenant-readmodel-writer/src/tenantConsumerServiceV1.ts
Outdated
Show resolved
Hide resolved
| { upsert: true } | ||
| ) | ||
| ) | ||
| .exhaustive(); |
There was a problem hiding this comment.
missing events
MaintenanceTenantPromotedToCertifierTenantMailDeleted
can you check exhaustive match here as well?
There was a problem hiding this comment.
At the beginning I seem to remember that it was not known whether these 2 events would be used or not, which is why they were added later with this PR
-
MaintenanceTenantPromotedToCertifier IMN-490 Add certifier id route in tenant-process #462
-
TenantMailDeleted IMN-466 DeleteTenantMailById route in tenant-process #454
beetlecrunch
requested changes
Jul 15, 2024
taglioni-r
approved these changes
Jul 16, 2024
galales
approved these changes
Jul 17, 2024
beetlecrunch
approved these changes
Jul 17, 2024
rGregnanin
deleted the
IMN-415_add_ConsumerServiceV2_in_tenant_readmodel_writer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[don't merge before #338]