IMN-587 - Upgrade agreement fix #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
changed the title
Viktor-K
force-pushed
the
test-bug-upgrade-agreement
branch
from
816e6f3
to
27f9568
Compare
ecamellini
previously requested changes
Jun 11, 2024
packages/agreement-process/src/services/agreementUpgradeProcessor.ts
Outdated
Show resolved
Hide resolved
ecamellini
reviewed
Jun 11, 2024
Viktor-K
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
changed the title
ecamellini
reviewed
Jun 13, 2024
There was a problem hiding this comment.
I took ownership of this PR and solved the comments so that @Viktor-K can focus on BFF, waiting for approval from others 👍
ecamellini
dismissed
their stale review
Took ownership of this PR and addressed the comments
ecamellini
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Added this test suite to reproduce the bug scenario and verify that it's solved.
galales
approved these changes
Jun 14, 2024
beetlecrunch
approved these changes
Jun 14, 2024
Co-authored-by: Alessio Gallitano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close IMN-587
Description
This PR fixes the IMN-587 bug and adds tests for the corresponding Agreement flows.
🔍 Analysis
On Agreement upgrade, a new Agreement is created, and this operation resets all suspension flags - in this way, those flags are lost and thus ignored during subsequent activation.
✅ Resolution
upgradeandsubmitAgreement operations preserve consumer/producer suspension flags.