IMN 606 - BFF purpose scaffolding #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalpenZibo
force-pushed
the
IMN-606_bff-purpose-router
branch
from
b28e8da
to
63b9beb
Compare
MalpenZibo
force-pushed
the
IMN-606_bff-purpose-router
branch
from
63b9beb
to
af95ab8
Compare
MalpenZibo
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
approved these changes
Jun 17, 2024
Comment on lines
+26
to
+27
| headers: { ...requestHeaders }, | ||
| withCredentials: true, |
There was a problem hiding this comment.
Will these two lines need to be duplicated in each client call? We could think about a way to avoid this and also the duplication of the definition of requestHeaders in each router call, even in a further PR
There was a problem hiding this comment.
I don't have a good solution right now, the only idea that I have is to wrap the client request in some way to inject these parameters
There was a problem hiding this comment.
ecamellini
reviewed
Jun 18, 2024
Viktor-K
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMN-606
How we currently handle the "zodiosPatch" for the BFF package is not optimal. Before implementing other solutions that require refactoring on other packages I'd like to discuss the
openApi spec firststrategy.