PIN-4810 clear tenant mail address #985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rGregnanin
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Here I am removing strange characters or special symbols | ||
| const sanitizedMail = removeExtraSpace | ||
| .replace(/[^\w.@-_]/g, "") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 17 hours ago
To fix the problem, we need to make the regular expression more precise by explicitly listing the characters we want to include instead of using a range that can match unintended characters. Specifically, we should replace the range @-_ with the exact characters we want to allow: @, ., -, and _.
- Update the regular expression on line 1899 to explicitly include the characters
@,.,-, and_instead of using the range@-_. - This change will ensure that only the intended characters are matched, avoiding the inclusion of unintended characters.
Suggested changeset
1
packages/tenant-process/src/services/tenantService.ts
| @@ -1898,3 +1898,3 @@ | ||
| const sanitizedMail = removeExtraSpace | ||
| .replace(/[^\w.@-_]/g, "") | ||
| .replace(/[^\w.@.\-_]/g, "") | ||
| .replace(/\^/g, ""); |
Copilot is powered by AI and may make mistakes. Always verify output.
AsterITA
reviewed
Sep 18, 2024
AsterITA
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.