chore(monitoring): add new action group #1164

Garma00 · 2024-09-16T12:19:59Z

List of changes

Add new io_com action group to alert related to shared resources;
Replace generic error action group with io_com action group for iocom resources.

Motivation and context

We want to isolate iocom related alert in a dedicated slack channel.

Type of changes

Add new resources
Update configuration to existing resources
Remove existing resources

Env to apply

DEV
UAT
PROD

Does this introduce a change to production resources with possible user impact?

Yes, users may be impacted applying this change
No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

Yes
No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

run deploy pipeline from Azure DevOps io-platform-iac-projects
select PR branch
wait for approval

github-actions · 2024-09-17T08:35:04Z

Terraform Plan ('src/domains/elt/prod/westeurope') 📖

Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # azurerm_resource_group.itn_elt will be destroyed
  # (because azurerm_resource_group.itn_elt is not in configuration)
  - resource "azurerm_resource_group" "itn_elt" {
      - id       = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01" -> null
      - location = "italynorth" -> null
      - name     = "io-p-itn-elt-rg-01" -> null
      - tags     = {
          - "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
          - "CreatedBy"      = "Terraform"
          - "Environment"    = "Prod"
          - "ManagementTeam" = "IO Platform"
          - "Owner"          = "IO"
          - "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        } -> null
    }

  # module.storage_accounts.azurerm_storage_container.messages_report_step1_itn will be destroyed
  # (because azurerm_storage_container.messages_report_step1_itn is not in configuration)
  - resource "azurerm_storage_container" "messages_report_step1_itn" {
      - container_access_type   = "private" -> null
      - has_immutability_policy = false -> null
      - has_legal_hold          = false -> null
      - id                      = "https://iopitneltst01.blob.core.windows.net/messages-report-step1" -> null
      - metadata                = {} -> null
      - name                    = "messages-report-step1" -> null
      - resource_manager_id     = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01/blobServices/default/containers/messages-report-step1" -> null
      - storage_account_name    = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_container.messages_report_step1_itn_02 will be destroyed
  # (because azurerm_storage_container.messages_report_step1_itn_02 is not in configuration)
  - resource "azurerm_storage_container" "messages_report_step1_itn_02" {
      - container_access_type   = "private" -> null
      - has_immutability_policy = false -> null
      - has_legal_hold          = false -> null
      - id                      = "https://iopitneltst02.blob.core.windows.net/messages-report-step1" -> null
      - metadata                = {} -> null
      - name                    = "messages-report-step1" -> null
      - resource_manager_id     = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02/blobServices/default/containers/messages-report-step1" -> null
      - storage_account_name    = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_container.messages_step_final_itn will be destroyed
  # (because azurerm_storage_container.messages_step_final_itn is not in configuration)
  - resource "azurerm_storage_container" "messages_step_final_itn" {
      - container_access_type   = "private" -> null
      - has_immutability_policy = false -> null
      - has_legal_hold          = false -> null
      - id                      = "https://iopitneltst01.blob.core.windows.net/messages-report-step-final" -> null
      - metadata                = {} -> null
      - name                    = "messages-report-step-final" -> null
      - resource_manager_id     = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01/blobServices/default/containers/messages-report-step-final" -> null
      - storage_account_name    = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_container.messages_step_final_itn_02 will be destroyed
  # (because azurerm_storage_container.messages_step_final_itn_02 is not in configuration)
  - resource "azurerm_storage_container" "messages_step_final_itn_02" {
      - container_access_type   = "private" -> null
      - has_immutability_policy = false -> null
      - has_legal_hold          = false -> null
      - id                      = "https://iopitneltst02.blob.core.windows.net/messages-report-step-final" -> null
      - metadata                = {} -> null
      - name                    = "messages-report-step-final" -> null
      - resource_manager_id     = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02/blobServices/default/containers/messages-report-step-final" -> null
      - storage_account_name    = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fneltcommands_itn will be destroyed
  # (because azurerm_storage_table.fneltcommands_itn is not in configuration)
  - resource "azurerm_storage_table" "fneltcommands_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fneltcommands')" -> null
      - name                 = "fneltcommands" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fneltcommands_itn_02 will be destroyed
  # (because azurerm_storage_table.fneltcommands_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fneltcommands_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fneltcommands')" -> null
      - name                 = "fneltcommands" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_itn will be destroyed
  # (because azurerm_storage_table.fnelterrors_itn is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fnelterrors')" -> null
      - name                 = "fnelterrors" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_itn_02 will be destroyed
  # (because azurerm_storage_table.fnelterrors_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fnelterrors')" -> null
      - name                 = "fnelterrors" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_message_status_itn will be destroyed
  # (because azurerm_storage_table.fnelterrors_message_status_itn is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_message_status_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fnelterrorsMessageStatus')" -> null
      - name                 = "fnelterrorsMessageStatus" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_message_status_itn_02 will be destroyed
  # (because azurerm_storage_table.fnelterrors_message_status_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_message_status_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fnelterrorsMessageStatus')" -> null
      - name                 = "fnelterrorsMessageStatus" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_messages_itn will be destroyed
  # (because azurerm_storage_table.fnelterrors_messages_itn is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_messages_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fnelterrorsMessages')" -> null
      - name                 = "fnelterrorsMessages" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_messages_itn_02 will be destroyed
  # (because azurerm_storage_table.fnelterrors_messages_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_messages_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fnelterrorsMessages')" -> null
      - name                 = "fnelterrorsMessages" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_notification_status_itn will be destroyed
  # (because azurerm_storage_table.fnelterrors_notification_status_itn is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_notification_status_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fnelterrorsNotificationStatus')" -> null
      - name                 = "fnelterrorsNotificationStatus" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fnelterrors_notification_status_itn_02 will be destroyed
  # (because azurerm_storage_table.fnelterrors_notification_status_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fnelterrors_notification_status_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fnelterrorsNotificationStatus')" -> null
      - name                 = "fnelterrorsNotificationStatus" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fneltexports_itn will be destroyed
  # (because azurerm_storage_table.fneltexports_itn is not in configuration)
  - resource "azurerm_storage_table" "fneltexports_itn" {
      - id                   = "https://iopitneltst01.table.core.windows.net/Tables('fneltexports')" -> null
      - name                 = "fneltexports" -> null
      - storage_account_name = "iopitneltst01" -> null
    }

  # module.storage_accounts.azurerm_storage_table.fneltexports_itn_02 will be destroyed
  # (because azurerm_storage_table.fneltexports_itn_02 is not in configuration)
  - resource "azurerm_storage_table" "fneltexports_itn_02" {
      - id                   = "https://iopitneltst02.table.core.windows.net/Tables('fneltexports')" -> null
      - name                 = "fneltexports" -> null
      - storage_account_name = "iopitneltst02" -> null
    }

  # module.function_apps.module.function_elt.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = {
          - "BLOB_COMMAND_STORAGE"                                                               = (sensitive value) -> null
            # (95 unchanged elements hidden)
        }
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Web/sites/io-p-fn-elt"
        name                                           = "io-p-fn-elt"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Platform"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (27 unchanged attributes hidden)

      ~ site_config {
          ~ health_check_eviction_time_in_min       = 0 -> 10
            # (24 unchanged attributes hidden)

            # (8 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }

  # module.function_apps.module.function_elt.azurerm_monitor_metric_alert.function_app_health_check[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "function_app_health_check" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Insights/metricAlerts/[IO-COMMONS | io-p-fn-elt] Health Check Failed"
        name                = "[IO-COMMONS | io-p-fn-elt] Health Check Failed"
        tags                = {}
        # (8 unchanged attributes hidden)

      + action {
          + action_group_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-msgs-rg-01/providers/Microsoft.Insights/actionGroups/io-p-com-error-ag-01"
        }

        # (2 unchanged blocks hidden)
    }

  # module.storage_accounts.module.storage_account_elt.azurerm_storage_account.this will be updated in-place
  ~ resource "azurerm_storage_account" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopstelt"
        name                              = "iopstelt"
        tags                              = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Platform"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (39 unchanged attributes hidden)

      ~ blob_properties {
          ~ change_feed_enabled           = true -> false
          ~ versioning_enabled            = true -> false
            # (2 unchanged attributes hidden)
        }

        # (3 unchanged blocks hidden)
    }

  # module.storage_accounts.module.storage_account_itn_elt.azurerm_advanced_threat_protection.this will be destroyed
  # (because azurerm_advanced_threat_protection.this is not in configuration)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01" -> null
    }

  # module.storage_accounts.module.storage_account_itn_elt.azurerm_storage_account.this will be destroyed
  # (because azurerm_storage_account.this is not in configuration)
  - resource "azurerm_storage_account" "this" {
      - access_tier                       = "Hot" -> null
      - account_kind                      = "StorageV2" -> null
      - account_replication_type          = "ZRS" -> null
      - account_tier                      = "Standard" -> null
      - allow_nested_items_to_be_public   = false -> null
      - cross_tenant_replication_enabled  = false -> null
      - default_to_oauth_authentication   = false -> null
      - enable_https_traffic_only         = true -> null
      - id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01" -> null
      - infrastructure_encryption_enabled = false -> null
      - is_hns_enabled                    = false -> null
      - local_user_enabled                = true -> null
      - location                          = "westeurope" -> null
      - min_tls_version                   = "TLS1_2" -> null
      - name                              = "iopitneltst01" -> null
      - nfsv3_enabled                     = false -> null
      - primary_access_key                = (sensitive value) -> null
      - primary_blob_connection_string    = (sensitive value) -> null
      - primary_blob_endpoint             = "https://iopitneltst01.blob.core.windows.net/" -> null
      - primary_blob_host                 = "iopitneltst01.blob.core.windows.net" -> null
      - primary_connection_string         = (sensitive value) -> null
      - primary_dfs_endpoint              = "https://iopitneltst01.dfs.core.windows.net/" -> null
      - primary_dfs_host                  = "iopitneltst01.dfs.core.windows.net" -> null
      - primary_file_endpoint             = "https://iopitneltst01.file.core.windows.net/" -> null
      - primary_file_host                 = "iopitneltst01.file.core.windows.net" -> null
      - primary_location                  = "westeurope" -> null
      - primary_queue_endpoint            = "https://iopitneltst01.queue.core.windows.net/" -> null
      - primary_queue_host                = "iopitneltst01.queue.core.windows.net" -> null
      - primary_table_endpoint            = "https://iopitneltst01.table.core.windows.net/" -> null
      - primary_table_host                = "iopitneltst01.table.core.windows.net" -> null
      - primary_web_endpoint              = "https://iopitneltst01.z6.web.core.windows.net/" -> null
      - primary_web_host                  = "iopitneltst01.z6.web.core.windows.net" -> null
      - public_network_access_enabled     = true -> null
      - queue_encryption_key_type         = "Service" -> null
      - resource_group_name               = "io-p-itn-elt-rg-01" -> null
      - secondary_access_key              = (sensitive value) -> null
      - secondary_connection_string       = (sensitive value) -> null
      - sftp_enabled                      = false -> null
      - shared_access_key_enabled         = true -> null
      - table_encryption_key_type         = "Service" -> null
      - tags                              = {
          - "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
          - "CreatedBy"      = "Terraform"
          - "Environment"    = "Prod"
          - "ManagementTeam" = "IO Platform"
          - "Owner"          = "IO"
          - "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        } -> null

      - blob_properties {
          - change_feed_enabled           = true -> null
          - change_feed_retention_in_days = 0 -> null
          - last_access_time_enabled      = false -> null
          - versioning_enabled            = true -> null
        }

      - network_rules {
          - bypass                     = [
              - "AzureServices",
            ] -> null
          - default_action             = "Allow" -> null
          - ip_rules                   = [] -> null
          - virtual_network_subnet_ids = [] -> null
        }

      - queue_properties {
          - hour_metrics {
              - enabled               = true -> null
              - include_apis          = true -> null
              - retention_policy_days = 7 -> null
              - version               = "1.0" -> null
            }
          - logging {
              - delete                = false -> null
              - read                  = false -> null
              - retention_policy_days = 0 -> null
              - version               = "1.0" -> null
              - write                 = false -> null
            }
          - minute_metrics {
              - enabled               = false -> null
              - include_apis          = false -> null
              - retention_policy_days = 0 -> null
              - version               = "1.0" -> null
            }
        }

      - share_properties {
          - retention_policy {
              - days = 7 -> null
            }
        }
    }

  # module.storage_accounts.module.storage_account_itn_elt_02.azurerm_advanced_threat_protection.this will be destroyed
  # (because azurerm_advanced_threat_protection.this is not in configuration)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02" -> null
    }

  # module.storage_accounts.module.storage_account_itn_elt_02.azurerm_storage_account.this will be destroyed
  # (because azurerm_storage_account.this is not in configuration)
  - resource "azurerm_storage_account" "this" {
      - access_tier                       = "Hot" -> null
      - account_kind                      = "StorageV2" -> null
      - account_replication_type          = "ZRS" -> null
      - account_tier                      = "Standard" -> null
      - allow_nested_items_to_be_public   = false -> null
      - cross_tenant_replication_enabled  = false -> null
      - default_to_oauth_authentication   = false -> null
      - enable_https_traffic_only         = true -> null
      - id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02" -> null
      - infrastructure_encryption_enabled = false -> null
      - is_hns_enabled                    = false -> null
      - local_user_enabled                = true -> null
      - location                          = "italynorth" -> null
      - min_tls_version                   = "TLS1_2" -> null
      - name                              = "iopitneltst02" -> null
      - nfsv3_enabled                     = false -> null
      - primary_access_key                = (sensitive value) -> null
      - primary_blob_connection_string    = (sensitive value) -> null
      - primary_blob_endpoint             = "https://iopitneltst02.blob.core.windows.net/" -> null
      - primary_blob_host                 = "iopitneltst02.blob.core.windows.net" -> null
      - primary_connection_string         = (sensitive value) -> null
      - primary_dfs_endpoint              = "https://iopitneltst02.dfs.core.windows.net/" -> null
      - primary_dfs_host                  = "iopitneltst02.dfs.core.windows.net" -> null
      - primary_file_endpoint             = "https://iopitneltst02.file.core.windows.net/" -> null
      - primary_file_host                 = "iopitneltst02.file.core.windows.net" -> null
      - primary_location                  = "italynorth" -> null
      - primary_queue_endpoint            = "https://iopitneltst02.queue.core.windows.net/" -> null
      - primary_queue_host                = "iopitneltst02.queue.core.windows.net" -> null
      - primary_table_endpoint            = "https://iopitneltst02.table.core.windows.net/" -> null
      - primary_table_host                = "iopitneltst02.table.core.windows.net" -> null
      - primary_web_endpoint              = "https://iopitneltst02.z38.web.core.windows.net/" -> null
      - primary_web_host                  = "iopitneltst02.z38.web.core.windows.net" -> null
      - public_network_access_enabled     = true -> null
      - queue_encryption_key_type         = "Service" -> null
      - resource_group_name               = "io-p-itn-elt-rg-01" -> null
      - secondary_access_key              = (sensitive value) -> null
      - secondary_connection_string       = (sensitive value) -> null
      - sftp_enabled                      = false -> null
      - shared_access_key_enabled         = true -> null
      - table_encryption_key_type         = "Service" -> null
      - tags                              = {
          - "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
          - "CreatedBy"      = "Terraform"
          - "Environment"    = "Prod"
          - "ManagementTeam" = "IO Platform"
          - "Owner"          = "IO"
          - "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        } -> null

      - blob_properties {
          - change_feed_enabled           = false -> null
          - change_feed_retention_in_days = 0 -> null
          - last_access_time_enabled      = false -> null
          - versioning_enabled            = true -> null
        }

      - network_rules {
          - bypass                     = [
              - "AzureServices",
            ] -> null
          - default_action             = "Allow" -> null
          - ip_rules                   = [] -> null
          - virtual_network_subnet_ids = [] -> null
        }

      - queue_properties {
          - hour_metrics {
              - enabled               = true -> null
              - include_apis          = true -> null
              - retention_policy_days = 7 -> null
              - version               = "1.0" -> null
            }
          - logging {
              - delete                = false -> null
              - read                  = false -> null
              - retention_policy_days = 0 -> null
              - version               = "1.0" -> null
              - write                 = false -> null
            }
          - minute_metrics {
              - enabled               = false -> null
              - include_apis          = false -> null
              - retention_policy_days = 0 -> null
              - version               = "1.0" -> null
            }
        }

      - share_properties {
          - retention_policy {
              - days = 7 -> null
            }
        }
    }

  # module.function_apps.module.function_elt.module.storage_account.azurerm_storage_account.this will be updated in-place
  ~ resource "azurerm_storage_account" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopstfnelt"
        name                              = "iopstfnelt"
        tags                              = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Platform"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (39 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.function_apps.module.function_elt.module.storage_account_durable_function[0].azurerm_storage_account.this will be updated in-place
  ~ resource "azurerm_storage_account" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopfneltsdt"
        name                              = "iopfneltsdt"
        tags                              = {
            "CostCenter"     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"      = "Terraform"
            "Environment"    = "Prod"
            "ManagementTeam" = "IO Platform"
            "Owner"          = "IO"
            "Source"         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (39 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 5 to change, 21 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

sonarcloud · 2024-09-30T15:11:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-30T15:20:44Z

📖 Terraform Plan ('src/domains/elt/prod') - success

Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # module.function_apps.module.function_elt.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Web/sites/io-p-fn-elt"
        name                                           = "io-p-fn-elt"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Platform"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/domains/elt/prod"
        }
        # (28 unchanged attributes hidden)

      ~ site_config {
          ~ health_check_eviction_time_in_min       = 0 -> 10
            # (26 unchanged attributes hidden)

            # (8 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }

  # module.function_apps.module.function_elt.azurerm_monitor_metric_alert.function_app_health_check[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "function_app_health_check" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Insights/metricAlerts/[IO-COMMONS | io-p-fn-elt] Health Check Failed"
        name                = "[IO-COMMONS | io-p-fn-elt] Health Check Failed"
        tags                = {}
        # (8 unchanged attributes hidden)

      + action {
          + action_group_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-msgs-rg-01/providers/Microsoft.Insights/actionGroups/io-p-com-error-ag-01"
        }

        # (2 unchanged blocks hidden)
    }

  # module.storage_accounts.module.storage_account_elt.azurerm_advanced_threat_protection.this has moved to module.storage_accounts.module.storage_account_elt.azurerm_advanced_threat_protection.this[0]
    resource "azurerm_advanced_threat_protection" "this" {
        id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopstelt/providers/Microsoft.Security/advancedThreatProtectionSettings/current"
        # (2 unchanged attributes hidden)
    }

  # module.storage_accounts.module.storage_account_itn_elt.azurerm_advanced_threat_protection.this[0] will be destroyed
  # (because index [0] is out of range for count)
  # (moved from module.storage_accounts.module.storage_account_itn_elt.azurerm_advanced_threat_protection.this)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst01" -> null
    }

  # module.storage_accounts.module.storage_account_itn_elt_02.azurerm_advanced_threat_protection.this[0] will be destroyed
  # (because index [0] is out of range for count)
  # (moved from module.storage_accounts.module.storage_account_itn_elt_02.azurerm_advanced_threat_protection.this)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-elt-rg-01/providers/Microsoft.Storage/storageAccounts/iopitneltst02" -> null
    }

  # module.function_apps.module.function_elt.module.storage_account.azurerm_advanced_threat_protection.this[0] will be destroyed
  # (because index [0] is out of range for count)
  # (moved from module.function_apps.module.function_elt.module.storage_account.azurerm_advanced_threat_protection.this)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopstfnelt/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopstfnelt" -> null
    }

  # module.function_apps.module.function_elt.module.storage_account_durable_function[0].azurerm_advanced_threat_protection.this[0] will be destroyed
  # (because index [0] is out of range for count)
  # (moved from module.function_apps.module.function_elt.module.storage_account_durable_function[0].azurerm_advanced_threat_protection.this)
  - resource "azurerm_advanced_threat_protection" "this" {
      - enabled            = false -> null
      - id                 = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopfneltsdt/providers/Microsoft.Security/advancedThreatProtectionSettings/current" -> null
      - target_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopfneltsdt" -> null
    }

  # module.function_apps.module.function_elt.module.storage_account_durable_function[0].azurerm_security_center_storage_defender.this[0] will be created
  + resource "azurerm_security_center_storage_defender" "this" {
      + id                                          = (known after apply)
      + malware_scanning_on_upload_cap_gb_per_month = -1
      + malware_scanning_on_upload_enabled          = false
      + override_subscription_settings_enabled      = false
      + sensitive_data_discovery_enabled            = false
      + storage_account_id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-elt-rg/providers/Microsoft.Storage/storageAccounts/iopfneltsdt"
    }

Plan: 1 to add, 2 to change, 4 to destroy.

Warning: Argument is deprecated

  with module.function_apps.module.function_elt.module.storage_account.azurerm_storage_account.this,
  on .terraform/modules/function_apps.function_elt.storage_account/storage_account/main.tf line 10, in resource "azurerm_storage_account" "this":
  10:   enable_https_traffic_only        = true

The property `enable_https_traffic_only` has been superseded by
`https_traffic_only_enabled` and will be removed in v4.0 of the AzureRM
Provider.

(and 10 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Garma00 · 2024-09-30T16:25:39Z

closing in favour of #1213

WIP: add new action group

872e40e

Garma00 temporarily deployed to prod-ci September 16, 2024 12:20 — with GitHub Actions Inactive

github-actions bot added the core label Sep 16, 2024

Garma00 added 7 commits September 17, 2024 09:51

WIP: add io_com action group to fn-elt

4f1fa32

WIP: replace common action group with io_com for NH alerts

56b10f5

WIP: add io_com action group to cqrs

acd7c24

WIP: add io_com action group to pushnotif

0b39614

WIP: add io_com action group to fn-services

4c9f992

chore: remove unused action group

072c789

merge with main

2fce8d2

Garma00 temporarily deployed to prod-ci September 17, 2024 08:34 — with GitHub Actions Inactive

Merge branch 'main' into iocom-1702-add-action-group

95887d4

Garma00 temporarily deployed to prod-ci September 17, 2024 08:53 — with GitHub Actions Inactive

Garma00 requested review from lucacavallaro, christian-calabrese and acuiuli September 17, 2024 09:02

Garma00 marked this pull request as ready for review September 17, 2024 09:02

Garma00 requested review from a team as code owners September 17, 2024 09:02

Garma00 temporarily deployed to prod-ci September 17, 2024 09:02 — with GitHub Actions Inactive

Garma00 had a problem deploying to prod-ci September 17, 2024 09:02 — with GitHub Actions Failure

Merge branch 'main' into iocom-1702-add-action-group

a09bc20

Garma00 temporarily deployed to prod-ci September 26, 2024 12:19 — with GitHub Actions Inactive

Merge branch 'main' into iocom-1702-add-action-group

15ad486

Garma00 temporarily deployed to prod-ci September 26, 2024 13:19 — with GitHub Actions Inactive

regenerate lock

f66c229

Garma00 temporarily deployed to prod-ci September 26, 2024 13:41 — with GitHub Actions Inactive

Garma00 added 2 commits September 26, 2024 16:36

Merge branch 'main' into iocom-1702-add-action-group

464c772

update fn elt storage

f14c34c

Garma00 temporarily deployed to prod-ci September 26, 2024 14:36 — with GitHub Actions Inactive

Merge branch 'main' into iocom-1702-add-action-group

78b8fa0

Garma00 temporarily deployed to prod-ci September 27, 2024 13:50 — with GitHub Actions Inactive

Merge branch 'main' into iocom-1702-add-action-group

8ed4250

Garma00 temporarily deployed to prod-ci September 30, 2024 10:11 — with GitHub Actions Inactive

Merge branch 'main' into iocom-1702-add-action-group

0ec0e05

Garma00 temporarily deployed to prod-ci September 30, 2024 14:17 — with GitHub Actions Inactive

Garma00 added 2 commits September 30, 2024 17:02

Merge branch 'main' into iocom-1702-add-action-group

21f2e61

chore(elt): restore advanced_threat_protection

4cb08a1

Garma00 temporarily deployed to prod-ci September 30, 2024 15:11 — with GitHub Actions Inactive

Garma00 closed this Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(monitoring): add new action group #1164

chore(monitoring): add new action group #1164

Garma00 commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

sonarcloud bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

Garma00 commented Sep 30, 2024

chore(monitoring): add new action group #1164

chore(monitoring): add new action group #1164

Conversation

Garma00 commented Sep 16, 2024 • edited Loading

List of changes

Motivation and context

Type of changes

Env to apply

Does this introduce a change to production resources with possible user impact?

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

github-actions bot commented Sep 17, 2024 • edited Loading

Terraform Plan ('src/domains/elt/prod/westeurope') 📖

sonarcloud bot commented Sep 30, 2024

Quality Gate passed

github-actions bot commented Sep 30, 2024

📖 Terraform Plan ('src/domains/elt/prod') - success

Garma00 commented Sep 30, 2024

Garma00 commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading