-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IOPID-1978] Remove old fn-fast-login from weu #1217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnedMarshal
force-pushed
the
IOPID-1978-remove-fast-login-weu
branch
from
October 3, 2024 15:03
dd5018f
to
1995f59
Compare
BurnedMarshal
had a problem deploying
to
prod-ci
October 3, 2024 15:03
— with
GitHub Actions
Failure
arcogabbo
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IaC LGTM, apart minor comment. there is a conflict with the main branch at the moment.
BurnedMarshal
force-pushed
the
IOPID-1978-remove-fast-login-weu
branch
from
October 8, 2024 07:19
1995f59
to
58cac5d
Compare
BurnedMarshal
force-pushed
the
IOPID-1978-remove-fast-login-weu
branch
from
October 10, 2024 12:09
a823164
to
3bab063
Compare
Quality Gate passedIssues Measures |
📖 Terraform Plan ('src/common/prod') - successTerraform Planmodule.application_gateway_weu.data.azurerm_linux_web_app.session_manager_03: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [10s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [10s elapsed]
data.azurerm_linux_function_app.app_messages_xl[0]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.app_messages_xl[1]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_selfcare_be: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_cgn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [20s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_cgn: Still reading... [20s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_continua: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager_04: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_assets_cdn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_profile[0]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_profile[1]: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_profile[0]: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_profile[1]: Still reading... [20s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app will be updated in-place
~ resource "azurerm_web_application_firewall_policy" "api_app" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-waf-appgateway-api-app-policy"
name = "io-p-waf-appgateway-api-app-policy"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra"
}
# (4 unchanged attributes hidden)
~ policy_settings {
~ request_body_inspect_limit_in_kb = 0 -> 128
# (6 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# module.cosmos_api_weu.azurerm_cosmosdb_sql_container.these["message-status"] will be updated in-place
~ resource "azurerm_cosmosdb_sql_container" "these" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.DocumentDB/databaseAccounts/io-p-cosmos-api/sqlDatabases/db/containers/message-status"
name = "message-status"
# (8 unchanged attributes hidden)
~ autoscale_settings {
~ max_throughput = 67000 -> 200000
}
# (2 unchanged blocks hidden)
}
# module.cosmos_api_weu.azurerm_cosmosdb_sql_container.these["messages"] will be updated in-place
~ resource "azurerm_cosmosdb_sql_container" "these" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.DocumentDB/databaseAccounts/io-p-cosmos-api/sqlDatabases/db/containers/messages"
name = "messages"
# (8 unchanged attributes hidden)
~ autoscale_settings {
~ max_throughput = 46000 -> 100000
}
# (2 unchanged blocks hidden)
}
# module.cosmos_api_weu.azurerm_cosmosdb_sql_container.these["profiles"] will be updated in-place
~ resource "azurerm_cosmosdb_sql_container" "these" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.DocumentDB/databaseAccounts/io-p-cosmos-api/sqlDatabases/db/containers/profiles"
name = "profiles"
# (7 unchanged attributes hidden)
~ autoscale_settings {
~ max_throughput = 48000 -> 100000
}
# (2 unchanged blocks hidden)
}
# module.app_backend_li_weu.module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendli"
name = "io-p-app-appbackendli"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (22 unchanged attributes hidden)
~ site_config {
# (25 unchanged attributes hidden)
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-weu-fast-login-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-citizen-auth-fast-login-snet-01"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-citizen-auth-fast-login-snet-01" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-msgs-sending-func-snet-01"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-msgs-sending-func-snet-01" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-services-snet-1"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-services-snet-1" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-services-snet-2"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-services-snet-2" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-admin-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-admin-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-citizen-auth-fast-login-snet-01"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-weu-fast-login-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-msgs-sending-func-snet-01"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
+ ip_address = "51.144.56.96/28"
name = "rule"
- virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-citizen-auth-fast-login-snet-01" -> null
# (3 unchanged attributes hidden)
}
~ ip_restriction {
+ ip_address = "51.144.56.112/28"
name = "rule"
- virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-msgs-sending-func-snet-01" -> null
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.96/28" -> "51.144.56.128/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.112/28" -> "51.144.56.144/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.128/28" -> "51.144.56.160/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.144/28" -> "51.144.56.176/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.160/28" -> "51.124.16.195/32"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.176/28" -> "51.105.109.140/32"
name = "rule"
# (3 unchanged attributes hidden)
}
- ip_restriction {
- action = "Allow" -> null
- headers = [] -> null
- ip_address = "51.124.16.195/32" -> null
- name = "rule" -> null
- priority = 65000 -> null
}
- ip_restriction {
- action = "Allow" -> null
- headers = [] -> null
- ip_address = "51.105.109.140/32" -> null
- name = "rule" -> null
- priority = 65000 -> null
}
# (4 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
# module.app_backend_weu["3"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl3"
name = "io-p-app-appbackendl3"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (22 unchanged attributes hidden)
~ site_config {
~ health_check_eviction_time_in_min = 0 -> 2
# (25 unchanged attributes hidden)
# (16 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
# module.application_gateway_weu.module.app_gw.azurerm_application_gateway.this will be updated in-place
~ resource "azurerm_application_gateway" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGateways/io-p-appgateway"
name = "io-p-appgateway"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra"
}
# (7 unchanged attributes hidden)
~ autoscale_configuration {
~ max_capacity = 50 -> 100
~ min_capacity = 10 -> 20
}
# (86 unchanged blocks hidden)
}
Plan: 0 to add, 7 to change, 0 to destroy.
Warning: Argument is deprecated
with module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app,
on ../_modules/application_gateway/firewall.tf line 62, in resource "azurerm_web_application_firewall_policy" "api_app":
62: disabled_rules = [
63: "942100",
64: "942120",
65: "942190",
66: "942200",
67: "942210",
68: "942240",
69: "942250",
70: "942260",
71: "942330",
72: "942340",
73: "942370",
74: "942380",
75: "942430",
76: "942440",
77: "942450",
78: ]
`disabled_rules` will be removed in favour of the `rule` property in version
4.0 of the AzureRM Provider.
(and 50 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
io-pagopa-github-bot
approved these changes
Oct 10, 2024
Krusty93
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Remove
fn-fast-login
in weu regionMotivation and context
The
fn-fast-login
was migrated to the ITN region, the old resources in weu must be removedType of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved