-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: use shouldReturnFocusOnClose #6984
base: develop
Are you sure you want to change the base?
Select: use shouldReturnFocusOnClose #6984
Conversation
Generate changelog in
|
@@ -122,8 +122,6 @@ export class Select<T> extends AbstractPureComponent<SelectProps<T>, SelectState | |||
|
|||
private queryList: QueryList<T> | null = null; | |||
|
|||
private previousFocusedElement: HTMLElement | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this previousFocusedElement
code does what Popover
's shouldReturnFocusOnClose
already does. Just use that.
In
Select
, all of thepreviousFocusedElement
code does whatPopover
'sshouldReturnFocusOnClose
already does. Just use that.