Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add disclaimer to options banner try it now link #10798

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 8, 2024


PR-Codex overview

This PR primarily focuses on replacing the usage of the deleted getOptionsUrl utility with a constant OPTIONS_URL throughout the codebase, while also updating the atomWithStorage function calls to include an additional option.

Detailed summary

  • Deleted getOptionsUrl.ts.
  • Introduced OPTIONS_URL constant in constants/index.ts.
  • Updated phishingBannerAtom and other atoms to include { unstable_getOnInit: true }.
  • Replaced instances of getOptionsUrl() with OPTIONS_URL in:
    • Menu/index.tsx
    • Menu/config/config.ts
    • OptionsBanner.tsx
  • Enhanced OptionsBanner component to handle user acknowledgment before redirecting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 10:47am

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 61d4bc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant