Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add banner and infostripe for PCSX #10826

Merged
merged 6 commits into from
Oct 17, 2024
Merged

feat: Add banner and infostripe for PCSX #10826

merged 6 commits into from
Oct 17, 2024
+254 −4

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Oct 15, 2024 •
edited by pr-codex bot
Loading

Add new banner and info stripe for PCS X
see:
https://linear.app/pancakeswap/issue/PAN-3937/add-new-banner-and-info-stripe-for-pcs-x

PR-Codex overview

This PR introduces the PCSXBanner component to the application, enhancing the user interface with new banners and features. It also refines the phishing banner logic and updates localization strings.

Detailed summary

  • Added PCSXBanner component with promotional content.
  • Integrated Step3 component into the PhishingWarningBanner.
  • Updated useMultipleBannerConfig to include PCSXBanner.
  • Modified phishing banner logic for better condition handling.
  • Expanded localization strings in translations.json.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6bd8252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 8:34am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am
blog ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am
games ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 8:34am

ChefJerry
ChefJerry previously approved these changes Oct 15, 2024
View reviewed changes
ChefMomota
ChefMomota previously approved these changes Oct 17, 2024
View reviewed changes
@ChefMomota
Copy link
Contributor

Mobile issue
Screenshot 2024-10-17 at 11 21 53 AM

@ChefMomota ChefMomota merged commit f4230b6 into develop Oct 17, 2024
19 checks passed
@ChefMomota ChefMomota deleted the feat/banner-oct15 branch October 17, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thechefpenguin thechefpenguin thechefpenguin left review comments

@ChefMomota ChefMomota ChefMomota approved these changes

@ChefJerry ChefJerry ChefJerry left review comments

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chef-ryan @ChefMomota @chefjackson @ChefJerry @thechefpenguin