Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards a 2D RG-PG-SGD #491

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Towards a 2D RG-PG-SGD #491

wants to merge 9 commits into from

Conversation

subwaystation
Copy link
Member

No description provided.

@subwaystation subwaystation changed the title Layout ref path Towards a 2D RG-PG-SGD Apr 3, 2023
@subwaystation
Copy link
Member Author

echo "gi|345525392:5000-18402" > ref.txt
odgi sort -i DRB1-3123_unsorted.og -o DRB1-3123.YH.og -H ref.txt -Y
odgi viz -i DRB1-3123.YH.og -o DRB1-3123.YH.og.png -du
odgi view -i DRB1-3123.YH.og -g > DRB1-3123.YH.gfa
odgi layout -i DRB1-3123.YH.gfa -o DRB1-3123.YH.gfa.layH -T DRB1-3123.YH.gfa.layH.tsv -P -t 1 -H ref.txt
./target/release/gfaestus ~/Downloads/ref/lay/DRB1-3123.YH.gfa ~/Downloads/ref/lay/DRB1-3123.YH.gfa.layH.tsv

This gives me

image

@AndreaGuarracino
Copy link
Member

AndreaGuarracino commented Aug 29, 2023 via email

@subwaystation
Copy link
Member Author

subwaystation commented Aug 30, 2023

aaah, oh god 🤥🫠

my implementation works as I intended, but conceptually, it is *****
in my naivity, I am just pasting the reference sequences from left to right
so if the 2nd reference sequence has nodes shared with the first one, I would generate long links ☠️
--> my implementation works well for one single reference genome or for one haplotype that is distributed across contigs in the graph, but not for several reference genomes🤌

I see 2 ways:

  • I take all reference sequences, fix their nodes and apply PG-SGD
  • Progressive approach as explained by erikg I take the 1st reference, paste it from left to right, fix its nodes and add the 2nd reference sequence by apply PG-SGD only to the unfixed nodes of the 2nd reference. In the next iteration, only the nodes of the 3rd reference sequence are unfixed, .....
  • Are there other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants