fix(CodeEditor): Set default height #11014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11014.surge.sh A11y report: https://patternfly-react-pr-11014-a11y.surge.sh |
rebeccaalpert
force-pushed
the
code-editor-height
branch
3 times, most recently
from
daec7e7
to
4b7c712
Compare
rebeccaalpert
force-pushed
the
code-editor-height
branch
from
cd0543f
to
7dfb53c
Compare
rebeccaalpert
force-pushed
the
code-editor-height
branch
2 times, most recently
from
824a30b
to
2f06af0
Compare
rebeccaalpert
changed the title
The docs state that the default height is 100%. However, the examples just break if you don't pass in a height. This should help.
rebeccaalpert
force-pushed
the
code-editor-height
branch
from
2f06af0
to
ae62ef8
Compare
tlabaj
approved these changes
Nov 13, 2024
|
This juSt needs core review @mcoker |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that the default height for CodeEditor is 100%. However, the examples just break if you don't pass in a height. I got it to work with these changes.
We just need to upgrade Core once a release comes out that contains these classes.
What: Closes #11013
Additional issues:
Related to patternfly/patternfly#7087