Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publication errors for @patternfly/react-charts #11042

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonkoops
Copy link
Contributor

Fixes the publication issues outlined by publint and some others, namely:

  • Add an explicit type field of module to the package.
  • Replace main, module and types fields with the more modern exports, which restricts the importable API surface.
  • Fix a misformatted URL in the repository field.
  • Remove sideEffects field that did not match any files.
  • Remove patternfly:src field, which seems to have no purpose.

Works towards closing #10833

@patternfly-build
Copy link
Contributor

patternfly-build commented Sep 21, 2024

@jonkoops
Copy link
Contributor Author

Putting this in as a draft as it seems the documenation tooling will need an update to make it compatible.

@jonkoops jonkoops marked this pull request as draft September 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants