Refactors and addressed some issues. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
No longer raises error when supplied a domain without a valid public suffix. Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Less ways for domainatrix to raise errors. Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Signed-off-by: Patrick Ma <[email protected]>
Solved #16 and #13 Signed-off-by: Patrick Ma <[email protected]>
|
hey guys, I'm finally getting around to pulling in requests and doing a new release of domainatrix. Can you take another look at this and update the pull request? Thanks! |
|
@PatrickMA - Actually I have been using your fork and there are some issues with Domain parsing: Can you please look into the same? Issue does not happen with Pauldix branch.. |
|
Before integrating this refactors, please take a look at this issue: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up a large method into smaller methods.
Simplified conditions.
Removed white space.
Domains with no public suffixes now return a empty string as the public_suffix value instead of raising errors. (Requested by issue #16)
Added a valid? method to the URL class. (Requested by issue #14)
Tested against issue #15.
Rescued against Addressable::URI::InvalidURIError exception.
Defaults to http scheme. #13.
Includes a couple other refactors, see diff.
99.25% test coverage. Took simplecov warnings from 16 to 10.
Rebased on Jamie Cobbett's 0.0.10 version of the gem.
Bumped version to 0.0.11 after covering issue #16.
Bumped version to 0.0.12 after covering issue #14.
Cheers.