Update this plugin to use latest plugin capability

composer.json

@@ -12,6 +12,6 @@
         }
     ],
     "require-dev": {
-        "phan/phan": "master"
+        "phan/phan": "^0.12.2"
     }
 }

src/UnusedVariablePlugin.php

@@ -23,8 +23,8 @@
 use Phan\Language\Element\FunctionInterface;
 use Phan\Language\Element\Variable;
 use Phan\PluginV2;
-use Phan\PluginV2\AnalyzeNodeCapability;
-use Phan\PluginV2\PluginAwareAnalysisVisitor;
+use Phan\PluginV2\PluginAwarePostAnalysisVisitor;
+use Phan\PluginV2\PostAnalyzeNodeCapability;
 use ast\Node;
 
 // By default, don't warn about parameters beginning with "$unused"
@@ -45,7 +45,7 @@
  *
  * It hooks into one event:
  *
- * - getAnalyzeNodeVisitorClassName
+ * - getPostAnalyzeNodeVisitorClassName
  *   This method returns a class that is called on every AST node from every
  *   file being analyzed
  *
@@ -62,13 +62,13 @@
  * add them to the corresponding section of README.md
  */
 final class UnusedVariablePlugin extends PluginV2
-    implements AnalyzeNodeCapability {
+    implements PostAnalyzeNodeCapability {
 
     /**
      * @return string - The name of the visitor that will be called (formerly analyzeNode)
      * @override
      */
-    public static function getAnalyzeNodeVisitorClassName() : string
+    public static function getPostAnalyzeNodeVisitorClassName() : string
     {
         return UnusedVariableReferenceAnnotatorVisitor::class;
     }
@@ -81,7 +81,7 @@ public static function getAnalyzeNodeVisitorClassName() : string
  * Visitors such as this are useful for defining lots of different
  * checks on a node based on its kind.
  */
-final class UnusedVariableReferenceAnnotatorVisitor extends PluginAwareAnalysisVisitor {
+final class UnusedVariableReferenceAnnotatorVisitor extends PluginAwarePostAnalysisVisitor {
     // A plugin's visitors should NOT implement visit(), unless they need to.
 
     // AST node types that would both can be references, and would affect analysis.
@@ -333,7 +333,7 @@ private function analyzeCallToMethodForReferences(
     }
 }
 
-class UnusedVariableVisitor extends PluginAwareAnalysisVisitor {
+class UnusedVariableVisitor extends PluginAwarePostAnalysisVisitor {
     const RECORD_ASSIGNS = false;
     const DONT_RECORD_ASSIGNS = true;
 

tests/expected/all_output.expected

@@ -18,9 +18,11 @@ src/000_all.php:468 PhanPluginUnusedVariable Variable is never used: $validate
 src/000_all.php:475 PhanPluginUnusedVariable Variable is never used: $a
 src/001_func.php:7 PhanPluginUnusedVariable Variable is never used: $one
 src/001_func.php:8 PhanPluginUnusedVariable Variable is never used: $two
+src/001_func.php:9 PhanNoopBinaryOperator Unused result of a binary '+' operator
 src/001_func.php:25 PhanPluginUnusedPublicMethodArgument Parameter is never used: $three
 src/002_closure.php:7 PhanPluginUnusedVariable Variable is never used: $one
 src/002_closure.php:8 PhanPluginUnusedVariable Variable is never used: $two
+src/002_closure.php:9 PhanNoopBinaryOperator Unused result of a binary '+' operator
 src/002_closure.php:24 PhanPluginUnusedPublicMethodArgument Parameter is never used: $three
 src/005_static_variables.php:24 PhanPluginUnusedVariable Variable is never used: $initialized
 src/006_references.php:14 PhanPluginUnusedPublicMethodArgument Parameter is never used: $fifteen