Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add container size difference as PR comment #328

Merged
merged 14 commits into from
Feb 27, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Feb 27, 2024

Pull Request

Description of changes

This PR adds functionality to show the size difference between the container size built from a PR and the latest version as a PR comment.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner February 27, 2024 10:51
@rjaegers rjaegers changed the title Feature/container-size-diff ci: add container size difference as PR comment Feb 27, 2024
Copy link
Contributor

github-actions bot commented Feb 27, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.71s
✅ DOCKERFILE hadolint 1 0 0.99s
✅ JSON eslint-plugin-jsonc 8 0 0 3.16s
✅ JSON prettier 8 0 0 0.47s
✅ JSON v8r 8 0 3.91s
✅ MARKDOWN markdownlint 8 0 0 1.09s
✅ MARKDOWN markdown-link-check 8 0 9.97s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.27s
✅ REPOSITORY checkov yes no 15.67s
✅ REPOSITORY gitleaks yes no 0.55s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 10.99s
✅ REPOSITORY secretlint yes no 1.47s
✅ REPOSITORY trivy yes no 8.43s
✅ REPOSITORY trivy-sbom yes no 3.36s
✅ REPOSITORY trufflehog yes no 6.81s
✅ SPELL lychee 43 0 0.91s
✅ YAML prettier 17 0 0 1.15s
✅ YAML v8r 17 0 14.08s
✅ YAML yamllint 17 0 0.37s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Test Results

20 tests  ±0   20 ✅ ±0   39s ⏱️ -3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7802e0a. ± Comparison against base commit 6833669.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer:latest to ghcr.io/philips-software/amp-devcontainer@sha256:059bfe984444e1dc4e587a2fcf700c1cde64ffd7ed6fed7f8f99d355bc9ade9f

OS/Platform Previous Size Current Size Delta
linux/amd64 594.66M 594.70M 40.01K (+0.01%)
linux/arm64 571.86M 571.90M 40.25K (+0.01%)

Copy link

@BarisTanyeri BarisTanyeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that there is a small delta on this PR (perhaps due to non-released "features"). In anyway, very good metric!

@rjaegers rjaegers added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 4a45cef Feb 27, 2024
14 checks passed
@rjaegers rjaegers deleted the feature/container-size-diff branch February 27, 2024 18:23
Copy link
Contributor

Pull Request Report (#328)

Static measures

Description Value
Number of added lines 84
Number of deleted lines 2
Number of changed files 5
Number of commits 14
Number of reviews 1
Number of comments (w/o review comments) 3
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 3

Time related measures

Description Value
PR lead time (from creation to close of PR) 7.5 Hours
Time that was spend on the branch before the PR was created 20.4 Hours
Time that was spend on the branch before the PR was merged 1.2 Days
Time to merge after last review 4.1 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 23.3 Min
Total time spend in last status check run on PR 16.2 Min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants