Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move iconv const check into autoconf #16847

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move iconv const check into autoconf #16847

wants to merge 2 commits into from
+12 −8

Commits on Nov 18, 2024

  1. Move iconv const check into autoconf 

    Some systems (older NetBSD pre-10, Solaris) may have a non-standard
const parameter with iconv. Instead of hardcoding the OS check, move
this to a feature check performed by autoconf.

autoconf doesn't have a nicer way of checking this (well, except for
AM_ICONV, which is part of gettext and we're presumably not using it),
so we have to repeat the function signature and check for it with a
mismatched signature.
    @NattyNarwhal
    NattyNarwhal committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    92add87 View commit details
    Browse the repository at this point in the history

  2. Fix quoted const on Windows

    @NattyNarwhal
    NattyNarwhal committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    63eb081 View commit details
    Browse the repository at this point in the history