Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

log backup result(success/failure) in backupmeta #1420

Open
IANTHEREAL opened this issue Aug 9, 2021 · 4 comments
Open

log backup result(success/failure) in backupmeta #1420

IANTHEREAL opened this issue Aug 9, 2021 · 4 comments
Labels
type/feature-request New feature or request

Comments

@IANTHEREAL
Copy link
Collaborator

IANTHEREAL commented Aug 9, 2021

Feature Request

Describe your feature request related problem:

The backup feature of TiDB is currently executed by a tool br. Now user can only monitoring the running of this tool br, and check the final log to confirm the backup result.

successful log example:

[2021/08/04 10:06:45.055 +08:00] [INFO] [collector.go:67] ["Full restore success summary"] [total-ranges=37] [ranges-succeed=37] [ranges-failed=0] [split-region=362.373805ms] [restore-checksum=6.890396086s] [restore-ranges=29] [total-take=17.328491842s] ["restore data size(after compressed)"=496.7MB] [total-kv=15462460] [total-kv-size=1.858GB] [average-speed=107.2MB/s]

But I consider that it's better to write the backup result to backup metadata. And after supporting backup/restore via SQL in TiDB, user can query the metadata through SQL.

This will make it easier for users to maintenance

Describe the feature you'd like:

log backup result(success/failure) in backupmeta

@IANTHEREAL IANTHEREAL added the type/feature-request New feature or request label Aug 9, 2021
@kennytm
Copy link
Collaborator

kennytm commented Aug 9, 2021

for BR in SQL you could do SHOW BACKUPS since pingcap/tidb#22699

@rahilsh
Copy link

rahilsh commented Aug 9, 2021

Is there a way for BR tool to call API(callback) of my service or push message to messaging service(kafka or sqs) when backup's state changes

@IANTHEREAL
Copy link
Collaborator Author

still not, currently it can only be achieved by writing a script, we will consider it later @rahilsh

@YuJuncen
Copy link
Collaborator

YuJuncen commented Aug 17, 2021

So I guess the final artifact should be a SQL stmt like SHOW BACKUP INFO IN $storage?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants