Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: backup: Add backup result into backupMeta #27292

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

joccau
Copy link
Member

@joccau joccau commented Aug 17, 2021

What problem does this PR solve?

Issue Number: close issue(pingcap/br#1420)

Problem Summary: Add the backup result into backupMeta

What is changed and how it works?

What's Changed:
Add a member(backup_result) in brpb.proto. Write the backupResult when Flush the backupmeta into storage

Note

The changes of brpb in pr(pingcap/kvproto#793)
After the pr(pingcap/kvproto#793) is merged, it can add merge flag in this PR

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Manual Test

./br backup full --pd "172.16.6.117:2379" --storage "local:///home/zak/backup_del" --check-requirements=false

The log
image

The tail part in backupmeta in storage
image

Release note

Add the backup result into `backupMeta` in the storage

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2021
@joccau
Copy link
Member Author

joccau commented Aug 17, 2021

/cc @3pointer
/cc @YuJuncen
/cc @glorv
/cc @kennytm
/cc @IANTHEREAL

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: YuJuncen.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @3pointer
/cc @YuJuncen
/cc @glorv
/cc @kennytm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Aug 17, 2021

/sig migrate

@joccau
Copy link
Member Author

joccau commented Aug 17, 2021

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Aug 17, 2021
}
}

func (tc *logCollector) CollectToStr(cmdName string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It there some reason we must use the log-like format here? Considering that our users usually won't read the backup meta directly, the format could be more friendly to computers. I would prefer to write them as a more structural format, say, JSON?
(Another benefit of using json is that we can use the zap itself to encode it)

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2021
@ti-chi-bot
Copy link
Member

@joccau: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

tiprow bot commented Feb 27, 2024

@joccau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 4115309 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Jul 31, 2024

@joccau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 4115309 link true /test build
idc-jenkins-ci-tidb/mysql-test 4115309 link true /test mysql-test
pull-integration-ddl-test 4115309 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/unit-test 4115309 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 4115309 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 4115309 link true /test check-dev2
pull-mysql-client-test 4115309 link true /test pull-mysql-client-test
pull-lightning-integration-test 4115309 link true /test pull-lightning-integration-test
pull-br-integration-test 4115309 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/migrate size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants