-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: backup: Add backup result into backupMeta
#27292
base: master
Are you sure you want to change the base?
Conversation
Solve the problem of multiple flush for backupmeta
Maintain the unit test after the modifying the MetaWriter
Delete the redundant code that appeared before
rename function from flushMetasV1 to fillMetasV1
rename function from FiniallyFlushBackupMeta to FlushBackupMeta
Add backup result to backupMeta
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @3pointer |
@joccau: GitHub didn't allow me to request PR reviews from the following users: YuJuncen. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. |
/sig migrate |
/component br |
} | ||
} | ||
|
||
func (tc *logCollector) CollectToStr(cmdName string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It there some reason we must use the log-like format here? Considering that our users usually won't read the backup meta directly, the format could be more friendly to computers. I would prefer to write them as a more structural format, say, JSON?
(Another benefit of using json is that we can use the zap itself to encode it)
@joccau: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@joccau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@joccau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close issue(pingcap/br#1420)
Problem Summary: Add the backup result into
backupMeta
What is changed and how it works?
What's Changed:
Add a member(backup_result) in brpb.proto. Write the
backupResult
when Flush thebackupmeta
into storageNote
The changes of brpb in pr(pingcap/kvproto#793)
After the pr(pingcap/kvproto#793) is merged, it can add merge flag in this PR
Tests
Manual Test
The log
The tail part in
backupmeta
in storageRelease note