Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: refactor br cli backoff logic #54644

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jul 15, 2024

What problem does this PR solve?

Issue Number: close #54643

Problem Summary:

Refactor the BR CLI backoff retry logic to make is more simplified and extendable in future.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

NA

Copy link

ti-chi-bot bot commented Jul 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. component/dumpling This is related to Dumpling of TiDB. labels Jul 15, 2024
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 15, 2024
Copy link

tiprow bot commented Jul 15, 2024

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

tests to be fixed
also pending on #54596

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger added component/br This issue is related to BR of TiDB. and removed component/dumpling This is related to Dumpling of TiDB. labels Jul 29, 2024
@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 1, 2024
Copy link

ti-chi-bot bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger, gmhdbjd for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 1, 2024
@Tristan1900 Tristan1900 marked this pull request as ready for review October 1, 2024 00:44
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Oct 1, 2024
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 72 lines in your changes missing coverage. Please review.

Project coverage is 76.0259%. Comparing base (74034d4) to head (81234e3).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54644        +/-   ##
================================================
+ Coverage   73.3645%   76.0259%   +2.6613%     
================================================
  Files          1624       1646        +22     
  Lines        448069     456076      +8007     
================================================
+ Hits         328724     346736     +18012     
+ Misses        99207      87699     -11508     
- Partials      20138      21641      +1503     
Flag Coverage Δ
integration 51.8350% <70.9677%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9211% <ø> (-0.0267%) ⬇️
parser ∅ <ø> (∅)
br 63.0593% <70.9677%> (+17.5463%) ⬆️

Copy link

ti-chi-bot bot commented Oct 1, 2024

@Tristan1900: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 81234e3 link true /test build
idc-jenkins-ci-tidb/unit-test 81234e3 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. component/dumpling This is related to Dumpling of TiDB. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: refactor CLI backoff retry logic
3 participants