Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pkg/config to pkg/configv1 #5237

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Copy pkg/config to pkg/configv1 #5237

merged 1 commit into from
Sep 27, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 27, 2024

What this PR does / why we need it:

This PR prepares the pkg/configv1 package to develop pipedv1.
This makes us to be able to reduce mistakenly breaking piped (v0).

The files under pkg/configv1 are copies of pkg/config with no modifications.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 51.86972% with 798 lines in your changes missing coverage. Please review.

Project coverage is 23.94%. Comparing base (1689c63) to head (e75d3e1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/configv1/piped.go 57.45% 252 Missing and 39 partials ⚠️
pkg/configv1/application.go 49.30% 160 Missing and 22 partials ⚠️
pkg/configv1/control_plane.go 34.23% 66 Missing and 7 partials ⚠️
pkg/configv1/config.go 55.83% 43 Missing and 10 partials ⚠️
pkg/configv1/event_watcher.go 59.22% 28 Missing and 14 partials ⚠️
pkg/configv1/launcher.go 0.00% 28 Missing ⚠️
pkg/configv1/analysis.go 46.80% 21 Missing and 4 partials ⚠️
pkg/configv1/application_kubernetes.go 8.00% 22 Missing and 1 partial ⚠️
pkg/configv1/application_ecs.go 36.36% 20 Missing and 1 partial ⚠️
pkg/configv1/replicas.go 69.56% 13 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5237      +/-   ##
==========================================
+ Coverage   22.92%   23.94%   +1.01%     
==========================================
  Files         420      437      +17     
  Lines       45336    46994    +1658     
==========================================
+ Hits        10392    11251     +859     
- Misses      34147    34838     +691     
- Partials      797      905     +108     
Flag Coverage Δ
23.94% <51.86%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go 👍

@Warashi Warashi merged commit 988949a into master Sep 27, 2024
15 of 17 checks passed
@Warashi Warashi deleted the pipedv1-configv1 branch September 27, 2024 01:21
@khanhtc1202 khanhtc1202 mentioned this pull request Sep 27, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants