-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s plugin's toolregistry implementation #5243
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
cd {{ .TmpDir }} | ||
curl -LO https://storage.googleapis.com/kubernetes-release/release/v{{ .Version }}/bin/{{ .Os }}/{{ .Arch }}/kubectl | ||
mv kubectl {{ .OutPath }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These template variables come from the below comments.
pipecd/pkg/app/pipedv1/cmd/piped/service/service.proto
Lines 46 to 51 in c1a06aa
// - {{ .Name }}: name of the tool. | |
// - {{ .Version }}: version of the tool. | |
// - {{ .OutPath }}: file path where the tool will be installed. | |
// - {{ .TmpDir }}: directory where the tool will be downloaded and extracted. | |
// - {{ .Arch }}: GOARCH of the current machine. | |
// - {{ .Os }}: GOOS of the current machine. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5243 +/- ##
==========================================
- Coverage 23.95% 23.94% -0.01%
==========================================
Files 437 438 +1
Lines 46997 47008 +11
==========================================
Hits 11258 11258
- Misses 34835 34846 +11
Partials 904 904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
What this PR does / why we need it:
The plugin has to pass the tool install script to the piped.
I don't want to pass a script everywhere the plugin tries to install a tool.
So I wrote a wrapper package to hide install script from other implementations.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No