Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test workflow #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bjohansebas
Copy link
Contributor

A workflow is added to run tests in GitHub Actions, in addition to being able to know from which version this package is supported using the engines field in the package.json

note: More tests should be added since the package does not work correctly after version 14 of Node.js.

closes #19

runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably drop a lot of these older ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From which version do you want to start testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now use lts versions

name: Run Tests

on:
push:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we limit this to pushes to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What should be the minimum supported version of Node.js for this package?
2 participants