-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test workflow #20
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/test.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably drop a lot of these older ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From which version do you want to start testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now use lts versions
1dafab3
to
4e892cf
Compare
4e892cf
to
ad1d02c
Compare
name: Run Tests | ||
|
||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we limit this to pushes to main?
A workflow is added to run tests in GitHub Actions, in addition to being able to know from which version this package is supported using the engines field in the package.json
note: More tests should be added since the package does not work correctly after version 14 of Node.js.
closes #19