Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staltz feedback #16

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Staltz feedback #16

wants to merge 5 commits into from

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Oct 24, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022

CLA assistant check
All committers have signed the CLA.

@mixmix mixmix changed the base branch from main to eager_avatars October 25, 2022 03:28
.use(require('ssb-ebt'))
// .use(require('ssb-conn'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: we see that turning off the default scheduler works amazingly for initial sync,
but not sure what the implication is long term. I think we need to make our own scheduler to make sure we have some connections live, but not too many, and cycle through them

const ssb = SSB()
const ssb = SSB({
ebt: {
// logging: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know about this. Currently not a documented feature

Copy link
Member Author

@mixmix mixmix Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as they want to change it to use better debug style logging like other modules

@mixmix mixmix marked this pull request as draft October 25, 2022 03:32
Base automatically changed from eager_avatars to main October 30, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants