-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug: page renders blank #315
base: 308_play_2.5
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Play2.5.4 | ||
|
||
## Environment | ||
play 2.5.4 | ||
scala 2.11 | ||
tomcat 8.0 | ||
servlet 3.1 | ||
|
||
## Build | ||
cd project-code | ||
sbt clean | ||
sbt -Dplay2war.sbt.scala211 -Dplay2.version=2.5.4 publishLocal | ||
|
||
## Project Usage | ||
- Modify {ProjectHome}/project/plugins.sbt | ||
|
||
``` | ||
addSbtPlugin("com.github.play2war" % "play2-war-plugin" % "1.5-beta1-SNAPSHOT") | ||
|
||
``` | ||
|
||
- Modify {ProjectHome}/build.sbt | ||
|
||
``` | ||
import com.github.play2war.plugin._ | ||
|
||
Play2WarPlugin.play2WarSettings | ||
Play2WarKeys.servletVersion := "3.1" | ||
Play2WarKeys.explodedJar := true | ||
|
||
``` | ||
|
||
- Package | ||
|
||
``` | ||
activator war | ||
|
||
``` | ||
|
||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,7 +165,7 @@ trait HttpServletRequestHandler extends RequestHandler { | |
// if (withContentLength || chunked) { | ||
val flow = body.dataStream.map { f ⇒ | ||
getHttpResponse().getRichOutputStream.foreach { os ⇒ | ||
os.write(f.asByteBuffer.array()) | ||
os.write(f.toArray) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. strange that the |
||
os.flush() | ||
} | ||
} | ||
|
@@ -176,7 +176,7 @@ trait HttpServletRequestHandler extends RequestHandler { | |
// cleanup() | ||
onHttpResponseComplete() | ||
case Failure(ex) => | ||
Logger("play").debug(ex.toString) | ||
Logger("play").error(ex.toString, ex) | ||
onHttpResponseComplete() | ||
} | ||
// } else { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,6 @@ resolvers += Resolver.typesafeRepo("releases") | |
|
||
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.3.2") | ||
|
||
addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0") | ||
addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0") | ||
|
||
addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "4.0.0") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please remove this plugin from the project code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this file?
Maybe you can copy those instructions into #308?