Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: page renders blank #315

Open
wants to merge 1 commit into
base: 308_play_2.5
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions Play2.5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Play2.5.4

## Environment
play 2.5.4
scala 2.11
tomcat 8.0
servlet 3.1

## Build
cd project-code
sbt clean
sbt -Dplay2war.sbt.scala211 -Dplay2.version=2.5.4 publishLocal

## Project Usage
- Modify {ProjectHome}/project/plugins.sbt

```
addSbtPlugin("com.github.play2war" % "play2-war-plugin" % "1.5-beta1-SNAPSHOT")

```

- Modify {ProjectHome}/build.sbt

```
import com.github.play2war.plugin._

Play2WarPlugin.play2WarSettings
Play2WarKeys.servletVersion := "3.1"
Play2WarKeys.explodedJar := true

```

- Package

```
activator war

```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this file?
Maybe you can copy those instructions into #308?

Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ trait HttpServletRequestHandler extends RequestHandler {
// if (withContentLength || chunked) {
val flow = body.dataStream.map { f ⇒
getHttpResponse().getRichOutputStream.foreach { os ⇒
os.write(f.asByteBuffer.array())
os.write(f.toArray)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that the ByteBuffer does not work...
👍 for fixing.

os.flush()
}
}
Expand All @@ -176,7 +176,7 @@ trait HttpServletRequestHandler extends RequestHandler {
// cleanup()
onHttpResponseComplete()
case Failure(ex) =>
Logger("play").debug(ex.toString)
Logger("play").error(ex.toString, ex)
onHttpResponseComplete()
}
// } else {
Expand Down
4 changes: 3 additions & 1 deletion project-code/project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ resolvers += Resolver.typesafeRepo("releases")

addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.3.2")

addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0")
addSbtPlugin("me.lessis" % "bintray-sbt" % "0.3.0")

addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "4.0.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this plugin from the project code?
For info, you can add it into ~/.sbt/0.13/plugins/sbteclipse.sbt for example.