prevent duplicate initialization of the dropzone. #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensens
force-pushed
the
fix-upload-dup-dropzone
branch
from
7026689
to
f83bf3d
Compare
jensens
force-pushed
the
fix-upload-dup-dropzone
branch
from
f83bf3d
to
eab8ccc
Compare
thet
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
all in all LGTM, except two suggestions:
- see my comment in the code
2) Please change the commit message to:
fix(pat-upload): Prevent duplicate initialization of the dropzone.
Fixes: https://github.com/plone/Products.CMFPlone/issues/3814
This would add this change automatically with the next release.
src/pat/upload/upload.js
Outdated
| @@ -61,6 +61,11 @@ export default Base.extend({ | |||
|
|
|||
| var self = this; | |||
|
|
|||
| if (self.$el.find(".upload-area").length) { | |||
| console.warn("Found already a dropzone on element, skipping!"); | |||
There was a problem hiding this comment.
I'd use the info level, otherwise people might get scared of a warning which is harmless.
Also, please use the logging infrastructure. I'd change it to:
import logger from "@patternslib/patternslib/src/core/logging";
const log = logger.getLogger("pat-upload");
[...]
if (self.$el.find(".upload-area").length) {
logger.info("Found already a dropzone on element, skipping!");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes plone/Products.CMFPlone#3814