Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of Boxplots with outliers #237

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tobiasvandriessel
Copy link

I added a Boxplot variant with outliers, but I don't know whether it's built the way you'd have liked, as I can imagine you would have liked to have it as a variant of a generic type. However, I decided to build something quick and dirty and figured you might as well think it's okay. I'm open to any suggestions, but I'm still a Rust beginner, so I'm not sure I can do exactly what you'd like.

Cheers.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #237 (32a577e) into master (96d5184) will increase coverage by 0.27%.
The diff coverage is 85.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   68.83%   69.11%   +0.27%     
==========================================
  Files          56       57       +1     
  Lines        4313     4439     +126     
==========================================
+ Hits         2969     3068      +99     
- Misses       1344     1371      +27     
Impacted Files Coverage Δ
src/element/mod.rs 33.33% <ø> (ø)
src/element/boxplot_outliers.rs 85.50% <85.50%> (ø)
src/chart/axes3d.rs 55.78% <0.00%> (-3.16%) ⬇️
src/coord/ranged3d/projection.rs 73.86% <0.00%> (-1.14%) ⬇️
src/chart/series.rs 61.70% <0.00%> (-1.07%) ⬇️
src/coord/ranged1d/combinators/logarithmic.rs 60.41% <0.00%> (-1.05%) ⬇️
src/chart/mesh.rs 34.78% <0.00%> (-0.97%) ⬇️
src/chart/context.rs 82.83% <0.00%> (-0.47%) ⬇️
src/coord/ranged1d/types/numeric.rs 86.08% <0.00%> (-0.12%) ⬇️
src/data/float.rs 93.75% <0.00%> (-0.10%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d5184...32a577e. Read the comment docs.

@wangjiawen2013
Copy link

Hi, do you resolve the conflicts ?

@tobiasvandriessel
Copy link
Author

@wangjiawen2013 I currently don't have the time to do so; I'll see if I can take a look in a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants