Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observers #6464

Closed
wants to merge 3 commits into from
Closed

Add observers #6464

wants to merge 3 commits into from

Conversation

Joshy3282
Copy link

@Joshy3282 Joshy3282 commented Oct 3, 2024

Introduction

Introduces observer block

Tests

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
  • Writing a test plugin (provide the code and sample output)
  • Other (provide details)
    image

@RezzaAbdillah
Copy link

Why don't you add a header license?

@IvanCraft623
Copy link
Member

the whole redstone logic is missing, which is in essence the main function of the Observer, so without a redstone implementation, there is no point in implementing it. In addition, if there is a plugin that intends to implement it properly, it will encounter the difficulty that it will not be able to overwrite the PM implementation.

Thanks for your contrubution, however redstone components cannot be implemented if there is no redstone functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants