Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Correct SpriteAnimator context type #2107

Merged

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Sep 24, 2024

Why

the types were technically lying

What

simply correct the type

Checklist

  • Ready to be merged

we can either keep it as nullable or provide a default value that is of type SpriteAnimatorState

example of default value:

const context = React.createContext<SpriteAnimatorState>({
  current: undefined,
  offset: undefined,
  hasEnded: undefined,
  ref: undefined,
})

Copy link

vercel bot commented Sep 24, 2024

@hichemfantar is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@netgfx netgfx merged commit 6ab0178 into pmndrs:master Sep 24, 2024
3 of 4 checks passed
@hichemfantar hichemfantar deleted the correct-sprite-animator-context-types branch September 24, 2024 12:02
Copy link

🎉 This PR is included in version 9.114.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants