Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use vite.config.ts as the sole config file #2109

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Sep 24, 2024

Why

the extra file seemed redundant

What

consolidate into one config file

Checklist

  • Ready to be merged

closes #2108

Copy link

vercel bot commented Sep 24, 2024

@hichemfantar is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@hichemfantar
Copy link
Contributor Author

marked as not ready because i'm not sure why things were setup like this.

perhaps @abernier can chime in?

@abernier abernier merged commit 7186407 into pmndrs:master Sep 24, 2024
3 of 4 checks passed
@hichemfantar hichemfantar deleted the correct-vite-config-files branch September 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are there two vite.config.ts and vite.config.js files?
2 participants