Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update three-mesh-bvh to version 0.8.0 #2112

Closed
wants to merge 1 commit into from

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Sep 27, 2024

Why

Updated three.js version to r158 where BatchedMesh is supported and available so certain bundlers do not fail on build.
https://github.com/gkjohnson/three-mesh-bvh/blob/master/CHANGELOG.md#080---2024-09-18

What

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Sep 27, 2024

@hichemfantar is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@abernier
Copy link
Member

build has failed https://github.com/pmndrs/drei/actions/runs/11064660446/job/30742905303?pr=2112#step:7:21

you can yarn build locally to test it out

@abernier
Copy link
Member

superseded by #2158

@abernier abernier closed this Oct 30, 2024
@hichemfantar hichemfantar deleted the bump-three-mesh-bvh branch October 30, 2024 20:56
@hichemfantar
Copy link
Contributor Author

details at #2158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants